[Lldb-commits] [PATCH] D71151: [lldb][test] Remove symlink for API tests.

2020-02-11 Thread Jordan Rupprecht via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG99451b445368: [lldb][test] Remove symlink for API tests. (authored by rupprecht). Changed prior to commit: https://reviews.llvm.org/D71151?vs=232658=243908#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D71151: [lldb][test] Remove symlink for API tests.

2020-02-07 Thread Jordan Rupprecht via Phabricator via lldb-commits
rupprecht added a comment. In D71151#1813772 , @labath wrote: > Judging by the direction of the lua patches, it doesn't look like we will > have lua "dotest" tests, so I think it's fine to just put this into API > directly (without the extra "test"

[Lldb-commits] [PATCH] D71151: [lldb][test] Remove symlink for API tests.

2020-01-10 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Judging by the direction of the lua patches, it doesn't look like we will have lua "dotest" tests, so I think it's fine to just put this into API directly (without the extra "test"

[Lldb-commits] [PATCH] D71151: [lldb][test] Remove symlink for API tests.

2019-12-10 Thread Jordan Rupprecht via Phabricator via lldb-commits
rupprecht added a comment. In D71151#1774586 , @labath wrote: > While I'm not opposed to moving "lldbsuite" to some place closer to the > tests, one thing I'd like to get out of this is to have the actual tests > stand out more prominently. Ditto; my

[Lldb-commits] [PATCH] D71151: [lldb][test] Remove symlink for API tests.

2019-12-09 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. While I'm not opposed to moving "lldbsuite" to some place closer to the tests, one thing I'd like to get out of this is to have the actual tests stand out more prominently. For that reason, I wouldn't want to just take the "lldbsuite" folder and "drop" it into

[Lldb-commits] [PATCH] D71151: [lldb][test] Remove symlink for API tests.

2019-12-06 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. Why don't we move the `lldbsuite` as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71151/new/ https://reviews.llvm.org/D71151 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D71151: [lldb][test] Remove symlink for API tests.

2019-12-06 Thread Jordan Rupprecht via Phabricator via lldb-commits
rupprecht created this revision. rupprecht added reviewers: labath, JDevlieghere. Herald added subscribers: lldb-commits, jfb, arphaman, atanasyan, mgrang, jrtc27, christof, kbarton, krytarowski, arichardson, nemanjai, emaste. Herald added a reviewer: espindola. Herald added a reviewer: jfb.