This revision was automatically updated to reflect the committed changes.
Closed by commit rG2c91d5ba8315: LanguageRuntime: Simplify
NSException::GetSummary() output (authored by mib).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71311/new/
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71311/new/
https://reviews.llvm.org/D71311
mib added a comment.
@davide I ran the Swift test suite both with and without my patch and got the
same results :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71311/new/
https://reviews.llvm.org/D71311
davide requested changes to this revision.
davide added a comment.
This revision now requires changes to proceed.
Did you test on swift?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71311/new/
https://reviews.llvm.org/D71311
mib updated this revision to Diff 233240.
mib added a comment.
Fixed patch submission
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71311/new/
https://reviews.llvm.org/D71311
Files:
mib updated this revision to Diff 233239.
mib added a comment.
Changed tests exception reasons.
Added print for when there is not reason.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71311/new/
https://reviews.llvm.org/D71311
Files:
davide added inline comments.
Comment at: lldb/source/Plugins/Language/ObjC/NSException.cpp:107-109
+ if (NSStringSummaryProvider(*reason_sp, reason_str_summary, options) &&
+ !reason_str_summary.Empty()) {
+stream.Printf("%s", reason_str_summary.GetData());
jingham added inline comments.
Comment at: lldb/source/Plugins/Language/ObjC/NSException.cpp:107-109
+ if (NSStringSummaryProvider(*reason_sp, reason_str_summary, options) &&
+ !reason_str_summary.Empty()) {
+stream.Printf("%s", reason_str_summary.GetData());
JDevlieghere added inline comments.
Comment at:
lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjNSException.py:30
'(NSException *) except1 = ',
-'name: @"TheGuyWhoHasNoName~1" - reason:
davide added a comment.
This one looks fine -- can you please check that this patch applied on swift
still produces something reasonable for mixed obj-C/swift formatters?
My guess is that it will, and you probably just need to update some tests.
Repository:
rG LLVM Github Monorepo
CHANGES
mib created this revision.
mib added a project: LLDB.
Right now, NSException::GetSummary() has the following output:
"name: $exception_name - reason: $exception_reason"
It would be better to simplify the output by removing the name and only
showing the exception's reason. This way, annotations
11 matches
Mail list logo
