[Lldb-commits] [PATCH] D71316: [FormatManager] Upstream and test swift bits for GetCandidateLanguages().

davide closed this revision. davide added a comment. Not relevant anymore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71316/new/ https://reviews.llvm.org/D71316 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D71316: [FormatManager] Upstream and test swift bits for GetCandidateLanguages().

davide added a comment. This is not a bad idea after all. Let me see if I can cook something reasonable without getting burned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71316/new/ https://reviews.llvm.org/D71316

[Lldb-commits] [PATCH] D71316: [FormatManager] Upstream and test swift bits for GetCandidateLanguages().

davide added a comment. Ideally -- if we're able to make this a callback in the language plugins, we don't need this patch at all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71316/new/ https://reviews.llvm.org/D71316

[Lldb-commits] [PATCH] D71316: [FormatManager] Upstream and test swift bits for GetCandidateLanguages().

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. The change looks good with some future refactoring comment inline. Comment at: lldb/source/DataFormatters/FormatManager.cpp:588 + case lldb::eLanguageTypeObjC: +

[Lldb-commits] [PATCH] D71316: [FormatManager] Upstream and test swift bits for GetCandidateLanguages().

davide created this revision. davide added reviewers: teemperor, aprantl, labath, friss, jingham. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D71316 Files: lldb/source/DataFormatters/FormatManager.cpp