[Lldb-commits] [PATCH] D71800: [CMake] Add $ORIGIN/../../../../lib to rpath if BUILD_SHARED_LIBS AND UNIX

labath added a comment. BTW, isn't a LLVM_LINK_LLVM_DYLIB build suffering from the same problem? Should that be included here too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71800/new/ https://reviews.llvm.org/D71800

[Lldb-commits] [PATCH] D71800: [CMake] Add $ORIGIN/../../../../lib to rpath if BUILD_SHARED_LIBS AND UNIX

labath added a comment. Yeah, not requiring LD_LIBRARY_PATH in the BUILD_SHARED_LIBS build would be nice. The fix isn't particularly pretty, but I don't know if there is a better way to do that (besides the improvements in inline comments). Comment at:

[Lldb-commits] [PATCH] D71800: [CMake] Add $ORIGIN/../../../../lib to rpath if BUILD_SHARED_LIBS AND UNIX

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: lldb/source/API/CMakeLists.txt:124 + set(_install_rpath "\$ORIGIN/../lib${LLVM_LIBDIR_SUFFIX}" "\$ORIGIN/../../../../lib${LLVM_LIBDIR_SUFFIX}" ${extra_libdir}) + set_target_properties(liblldb

[Lldb-commits] [PATCH] D71800: [CMake] Add $ORIGIN/../../../../lib to rpath if BUILD_SHARED_LIBS AND UNIX

MaskRay created this revision. MaskRay added reviewers: clayborg, JDevlieghere, jingham, labath. Herald added subscribers: lldb-commits, kristof.beyls, mgorny. Herald added a project: LLDB. For -DBUILD_SHARED_LIBS=On builds, lib/liblldb.so depends on lib/*.so .