This revision was automatically updated to reflect the committed changes.
Closed by commit rGbbfebd7b8a67: [CMake] Add $ORIGIN/../../../../lib to rpath
if BUILD_SHARED_LIBS or… (authored by MaskRay).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Thanks. I think this is fine now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71800/new/
https://reviews.llvm.org/D71800
MaskRay added a comment.
Ping:)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71800/new/
https://reviews.llvm.org/D71800
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
MaskRay updated this revision to Diff 235170.
MaskRay marked 3 inline comments as done.
MaskRay retitled this revision from "[CMake] Add $ORIGIN/../../../../lib to
rpath if BUILD_SHARED_LIBS AND UNIX" to "[CMake] Add $ORIGIN/../../../../lib to
rpath if BUILD_SHARED_LIBS or LLVM_LINK_LLVM_DYLIB
MaskRay added inline comments.
Comment at: lldb/source/API/CMakeLists.txt:117
+# loaded from Python.
+if(LLDB_ENABLE_PYTHON AND BUILD_SHARED_LIBS AND UNIX)
+ if(LLVM_INSTALL_PREFIX AND NOT (LLVM_INSTALL_PREFIX STREQUAL
CMAKE_INSTALL_PREFIX))
labath wrote:
> I