[Lldb-commits] [PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

MaskRay added a comment. In D71857#1804307 , @Mordante wrote: > In D71857#1800663 , @MaskRay wrote: > > > I think there is a false positive. > > > >

[Lldb-commits] [PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

Mordante added a comment. In D71857#1800663 , @MaskRay wrote: > I think there is a false positive. > > https://github.com/llvm/llvm-project/tree/master/lld/ELF/Relocations.cpp#L1622 > > for (const std::pair ts : isd->thunkSections) > Removing the

[Lldb-commits] [PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

Mordante added a comment. In D71857#1800663 , @MaskRay wrote: > However, I am afraid I don't like some of the fixes here. You can replace > `const auto` with `const auto &` and call that a fix... IMHO if the type is > not obvious, `const ConcreteType &`

[Lldb-commits] [PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

MaskRay added a comment. I really like the new feature. Thanks for making the efforts! However, I am afraid I don't like some of the fixes here. You can replace `const auto` with `const auto &` and call that a fix... IMHO if the type is not obvious, `const ConcreteType &` will be better. In

[Lldb-commits] [PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rG8dc7b982b455: [NFC] Fixes -Wrange-loop-analysis warnings (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71857/new/

[Lldb-commits] [PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

Mordante updated this revision to Diff 235763. Mordante retitled this revision from "Fixes -Wrange-loop-analysis warnings" to "[NFC] Fixes -Wrange-loop-analysis warnings". Mordante added a comment. Reviewed the types and added a `*` for pointers and added a `const` when applicable. CHANGES

[Lldb-commits] [PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

Mordante marked 8 inline comments as done. Mordante added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.cpp:22 #include "lldb/Target/Process.h" #include "lldb/Utility/Log.h"

[Lldb-commits] [PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71857/new/ https://reviews.llvm.org/D71857 ___

[Lldb-commits] [PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

Mordante marked 2 inline comments as done. Mordante added a comment. Thanks for the review! I'll commit all the -Wrange-loop-analysis patches later today. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71857/new/ https://reviews.llvm.org/D71857