[Lldb-commits] [PATCH] D74903: [lldb][test] Add two wrapper functions to manage settings in test-suite

2020-02-21 Thread Pavel Labath via Phabricator via lldb-commits
labath added a subscriber: jingham. labath added a comment. We (mostly me and @jingham) discussed that idea (very) briefly a couple of weeks ago, and my impression was that this (reinitializing SBDebugger for every test) would be a good way to go. There are just too many things that can leak

[Lldb-commits] [PATCH] D74903: [lldb][test] Add two wrapper functions to manage settings in test-suite

2020-02-21 Thread Tatyana Krasnukha via Phabricator via lldb-commits
tatyana-krasnukha added a comment. I like this idea and ready to implement, but I'm not aware of the reasons why the current implementation was chosen. Suppose that initializing the Debugger for each test will slow down the test-suite significantly. Repository: rLLDB LLDB CHANGES SINCE

[Lldb-commits] [PATCH] D74903: [lldb][test] Add two wrapper functions to manage settings in test-suite

2020-02-20 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. I'm kinda curious how much we actually support this? I know we do a lot of random fiddling with settings and what not, but I feel if we anyway say that each test needs to have a clean setup, can't we just create like a new SBDebugger instance or something like that

[Lldb-commits] [PATCH] D74903: [lldb][test] Add two wrapper-functions to manage settings in test-suite

2020-02-20 Thread Tatyana Krasnukha via Phabricator via lldb-commits
tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: JDevlieghere, labath. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, teemperor. Some tests set settings and don't clean them up, this leads to side effects in other tests. The patch