[Lldb-commits] [PATCH] D76045: [lldb/API] Make Launch(Simple) use args and env from target properties

2020-03-23 Thread Frederic Riss via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGcd7b45057ca9: [lldb/API] Make Launch(Simple) use args and env from target properties (authored by friss). Changed prior to commit: https://reviews.llvm.org/D76045?vs=249834=252051#toc Repository: rG

[Lldb-commits] [PATCH] D76045: [lldb/API] Make Launch(Simple) use args and env from target properties

2020-03-12 Thread Frederic Riss via Phabricator via lldb-commits
friss added a comment. This is somewhat useless without D76009 because the default LaunchInfo doesn't get populated with the environment without it. I'll wait for a resolution there before landing this. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D76045: [lldb/API] Make Launch(Simple) use args and env from target properties

2020-03-12 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. sounds reasonable. Comment at: lldb/include/lldb/API/SBTarget.h:130-132 + /// The environment array. If this isn't provided, the default + /// environment values

[Lldb-commits] [PATCH] D76045: [lldb/API] Make Launch(Simple) use args and env from target properties

2020-03-11 Thread Frederic Riss via Phabricator via lldb-commits
friss created this revision. friss added reviewers: jingham, labath. Herald added projects: LLDB, libc++abi. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++abi. friss updated this revision to Diff 249834. friss added a comment. friss removed a reviewer: libc++abi. friss

[Lldb-commits] [PATCH] D76045: [lldb/API] Make Launch(Simple) use args and env from target properties

2020-03-11 Thread Frederic Riss via Phabricator via lldb-commits
friss updated this revision to Diff 249834. friss added a comment. Remove unrelated change commited by accident Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76045/new/ https://reviews.llvm.org/D76045 Files: lldb/include/lldb/API/SBTarget.h