This revision was automatically updated to reflect the committed changes.
Closed by commit rG177dd63c8d74: Data formatters: fix detection of C strings
(authored by jarin, committed by teemperor).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76650/ne
jarin updated this revision to Diff 252276.
jarin marked 2 inline comments as done.
jarin added a comment.
Addressed reviewer comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76650/new/
https://reviews.llvm.org/D76650
Files:
lldb/source/C
jarin added a comment.
Thanks for the review! Could you possibly land this for me?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76650/new/
https://reviews.llvm.org/D76650
___
lldb-commits mailing list
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for tracking this down! I only have a minor comment about the test
character.
Comment at:
lldb/test/API/functionalities/data-formatter/cstring-utf8-summa
jarin created this revision.
jarin added a reviewer: teemperor.
jarin added a project: LLDB.
Herald added a subscriber: lldb-commits.
Detection of C strings does not work well for pointers. If the value object
holding a (char*) pointer does not have an address (e.g., if it is a temp), the
value
