[Lldb-commits] [PATCH] D76697: [lldb] Replace debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType with lldbassert

2023-01-30 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG8b1cd3749eb6: [lldb] Use lldbassert in BuildObjCObjectPointerType (authored by JDevlieghere). Herald added a project:

[Lldb-commits] [PATCH] D76697: [lldb] Replace debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType with lldbassert

2023-01-25 Thread Davide Italiano via Phabricator via lldb-commits
davide added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76697/new/ https://reviews.llvm.org/D76697 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D76697: [lldb] Replace debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType with lldbassert

2020-04-13 Thread Vedant Kumar via Phabricator via lldb-commits
vsk added a comment. The change looks reasonable to me. @davide? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76697/new/ https://reviews.llvm.org/D76697 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D76697: [lldb] Replace debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType with lldbassert

2020-04-13 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a subscriber: kkleine. teemperor added a comment. @kkleine yes, that's correct. So what should happen with this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76697/new/ https://reviews.llvm.org/D76697 ___ lldb-commits

[Lldb-commits] [PATCH] D76697: [lldb] Replace debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType with lldbassert

2020-03-26 Thread Konrad Wilhelm Kleine via Phabricator via lldb-commits
kwk added a comment. Let's summarize this. 1. In the old and the new version, the program is aborted with an `assert()` if the configuration is `LLDB_CONFIGURATION_DEBUG`. 2. In the old version, nothing happens, when the configuration is non-Debug. 3. In the new version, the assert in non-Debug

[Lldb-commits] [PATCH] D76697: [lldb] Replace debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType with lldbassert

2020-03-25 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor updated this revision to Diff 252517. teemperor retitled this revision from "[lldb] Remove Debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType" to "[lldb] Replace debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType with lldbassert".