[Lldb-commits] [PATCH] D76827: [lldb/CMake] Fix `install` for multi-configuration generators.

JDevlieghere added a comment. In D76827#1947176 , @brooks wrote: > Doing a bit of naive digging suggests to me that putting this section inside > an > > if (NOT CMAKE_CFG_INTDIR STREQUAL ".") > > > might do the trick. I can reproduce this with the

[Lldb-commits] [PATCH] D76827: [lldb/CMake] Fix `install` for multi-configuration generators.

brooks added a comment. Doing a bit of naive digging suggests to me that putting this section inside an if (NOT CMAKE_CFG_INTDIR STREQUAL ".") might do the trick. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76827/new/

[Lldb-commits] [PATCH] D76827: [lldb/CMake] Fix `install` for multi-configuration generators.

NathanielMcVicar added a comment. > Hey Brooks, do you have a public buildbot so I can try to fix it? What > generator are you using? We are also experiencing a similar install failure on Ubuntu. Unfortunately we don't have a lldb buildbot for this platform either. I should have spoken up

[Lldb-commits] [PATCH] D76827: [lldb/CMake] Fix `install` for multi-configuration generators.

JDevlieghere added a comment. In D76827#1947070 , @brooks wrote: > This is broken in a FreeBSD install. > > CMake Error at tools/lldb/cmake_install.cmake:44 (file): > file INSTALL cannot find >

[Lldb-commits] [PATCH] D76827: [lldb/CMake] Fix `install` for multi-configuration generators.

brooks added a subscriber: emaste. brooks added a comment. The generator is Ninja. @emaste may know of a buildbot. Note that this is an install failure so I'm not sure if buildbots will catch it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D76827: [lldb/CMake] Fix `install` for multi-configuration generators.

brooks added a comment. This is broken in a FreeBSD install. CMake Error at tools/lldb/cmake_install.cmake:44 (file): file INSTALL cannot find

[Lldb-commits] [PATCH] D76827: [lldb/CMake] Fix `install` for multi-configuration generators.

This revision was automatically updated to reflect the committed changes. Closed by commit rG17e4c38739aa: [lldb/CMake] Fix `install` for multi-configuration generators. (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D76827: [lldb/CMake] Fix `install` for multi-configuration generators.

JDevlieghere added a comment. In D76827#1944229 , @NathanielMcVicar wrote: > This patch resolved the issue for our VS build. Thanks! Unfortunately, I > don't have any way to test it for Xcode. Should I still accept the revision? I've tested it for

[Lldb-commits] [PATCH] D76827: [lldb/CMake] Fix `install` for multi-configuration generators.

NathanielMcVicar added a comment. This patch resolved the issue for our VS build. Thanks! Unfortunately, I don't have any way to test it for Xcode. Should I still accept the revision? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76827/new/

[Lldb-commits] [PATCH] D76827: [lldb/CMake] Fix `install` for multi-configuration generators.

JDevlieghere created this revision. JDevlieghere added reviewers: stella.stamenova, NathanielMcVicar. Herald added a subscriber: mgorny. For multi-generator builds like MSVC and Xcode, the install source and destination of the `lldb-python-scripts` target contains configuration dependent paths