[Lldb-commits] [PATCH] D77107: [intel-pt] Implement a basic test case

This revision was automatically updated to reflect the committed changes. Closed by commit rGf1242ec54306: [intel-pt] Implement a basic test case (authored by Walter Erquinigo wall...@fb.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77107/new/

[Lldb-commits] [PATCH] D77107: [intel-pt] Implement a basic test case

wallace marked an inline comment as done. wallace added inline comments. Comment at: lldb/test/API/tools/intel-features/intel-pt/test/main.cpp:2-8 + + Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. + See https://llvm.org/LICENSE.txt

[Lldb-commits] [PATCH] D77107: [intel-pt] Implement a basic test case

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/API/tools/intel-features/intel-pt/test/TestIntelPTSimpleBinary.py:50-54 +"rand", # We expect to see a reference to the rand

[Lldb-commits] [PATCH] D77107: [intel-pt] Implement a basic test case

wallace updated this revision to Diff 254067. wallace added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77107/new/ https://reviews.llvm.org/D77107 Files: lldb/test/API/tools/intel-features/intel-pt/test/Makefile

[Lldb-commits] [PATCH] D77107: [intel-pt] Implement a basic test case

wallace updated this revision to Diff 254068. wallace added a comment. Noise, for some reason I can't run clang-format as part of arc lint on this device. I'm running it manually anyway Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77107/new/

[Lldb-commits] [PATCH] D77107: [intel-pt] Implement a basic test case

wallace updated this revision to Diff 254065. wallace added a comment. Addressed comments Also ran the test in parallel to a 'stress -c 100 -i 100' invocation, and it passed correctly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77107/new/

[Lldb-commits] [PATCH] D77107: [intel-pt] Implement a basic test case

wallace marked 2 inline comments as done. wallace added inline comments. Comment at: lldb/test/API/tools/intel-features/intel-pt/test/TestIntelPTSimpleBinary.py:50-54 +"rand", # We expect to see a reference to the rand function +# within

[Lldb-commits] [PATCH] D77107: [intel-pt] Implement a basic test case

labath added a comment. It's nice to see this code getting some use. I was starting to think we should delete it... Comment at: lldb/test/API/tools/intel-features/intel-pt/test/TestIntelPTSimpleBinary.py:30-36 +exe = self.getBuildArtifact("a.out") +

[Lldb-commits] [PATCH] D77107: [intel-pt] Implement a basic test case

clayborg added a comment. I am worried if this test will be flaky on loaded machines. Not sure how we can ever guarantee we will see processor traces with our stuff in it if the machine is busy running many tests or even doing other things. Comment at:

[Lldb-commits] [PATCH] D77107: [intel-pt] Implement a basic test case

wallace updated this revision to Diff 253748. wallace added a comment. Added a stop command invocation in the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77107/new/ https://reviews.llvm.org/D77107 Files:

[Lldb-commits] [PATCH] D77107: [intel-pt] Implement a basic test case

wallace created this revision. wallace added reviewers: clayborg, labath, kusmour, aadsm. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. wallace updated this revision to Diff 253748. wallace added a comment. Added a stop command invocation in the test Depends on D76872