[Lldb-commits] [PATCH] D77186: [source maps] Ensure all valid source maps are added instead of failing with the first invalid one

labath added a comment. In D77186#1955640 , @wallace wrote: > Thanks for the heads up. I think I got a false impression of how comments > after accept vs requesting changes work in this repo. The rules on that are somewhat fuzzy, but there has been a

[Lldb-commits] [PATCH] D77186: [source maps] Ensure all valid source maps are added instead of failing with the first invalid one

wallace added a comment. Thanks for the heads up. I think I got a false impression of how comments after accept vs requesting changes work in this repo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77186/new/ https://reviews.llvm.org/D77186

[Lldb-commits] [PATCH] D77186: [source maps] Ensure all valid source maps are added instead of failing with the first invalid one

MaskRay added a comment. In D77186#1955451 , @wallace wrote: > address comments @wallace labath made comments after the differential had been approved. So it looks like he may have further questions. It was probably better waiting for an explicit ack

[Lldb-commits] [PATCH] D77186: [source maps] Ensure all valid source maps are added instead of failing with the first invalid one

This revision was automatically updated to reflect the committed changes. Closed by commit rG30350c254106: [source maps] Ensure all valid source maps are added instead of failing with… (authored by Walter Erquinigo walterme...@fb.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D77186: [source maps] Ensure all valid source maps are added instead of failing with the first invalid one

wallace updated this revision to Diff 254268. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77186/new/ https://reviews.llvm.org/D77186 Files: lldb/source/Interpreter/OptionValuePathMappings.cpp

[Lldb-commits] [PATCH] D77186: [source maps] Ensure all valid source maps are added instead of failing with the first invalid one

wallace marked 4 inline comments as done. wallace added inline comments. Comment at: lldb/source/Interpreter/OptionValuePathMappings.cpp:73 changed = true; +idx++; } else { labath wrote: > does this actually change anything?

[Lldb-commits] [PATCH] D77186: [source maps] Ensure all valid source maps are added instead of failing with the first invalid one

labath added a comment. It seems somewhat odd for a command to return error (one of the effects of that for instance is to abort processing of batch scripts), but still perform some changes. It might be more appropriate to call those warnings. However, reporting warnings from here would

[Lldb-commits] [PATCH] D77186: [source maps] Ensure all valid source maps are added instead of failing with the first invalid one

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. This will do what the user intends more of the time. Good catch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77186/new/

[Lldb-commits] [PATCH] D77186: [source maps] Ensure all valid source maps are added instead of failing with the first invalid one

wallace created this revision. wallace added reviewers: clayborg, labath, kusmour, aadsm. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Several lldb-vscode users have noticed that when a source map rule is invalid (because a folder doesn't exist anymore), the rest of the