[Lldb-commits] [PATCH] D78807: Fix gendered documentation

2020-11-02 Thread Ronan Keryell via Phabricator via lldb-commits
keryell added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/google-objc-global-variable-declaration.rst:47 The check will give a warning message but will not be able to suggest a fix. The -user need to fix it on his own. +user needs to fix it on their

[Lldb-commits] [PATCH] D78807: Fix gendered documentation

2020-10-31 Thread Sylvestre Ledru via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG43e451f9f316: Fix gendered documentation (authored by pedro.gonnet, committed by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78807/new/

Re: [Lldb-commits] [PATCH] D78807: Fix gendered documentation

2020-04-24 Thread Jim Ingham via lldb-commits
A lot of our comments and documentation was written a while ago when the “good” practice was to be careful to use “he” and “she” in equal measure when referring to our users. The consensus has shifted to using “they” instead, so there are probably a bunch of other places using he and she.

[Lldb-commits] [PATCH] D78807: Fix gendered documentation

2020-04-24 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78807/new/ https://reviews.llvm.org/D78807 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D78807: Fix gendered documentation

2020-04-24 Thread Sylvestre Ledru via Phabricator via lldb-commits
sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78807/new/ https://reviews.llvm.org/D78807

[Lldb-commits] [PATCH] D78807: Fix gendered documentation

2020-04-24 Thread Pedro Gonnet via Phabricator via lldb-commits
pedro.gonnet created this revision. pedro.gonnet added reviewers: JDevlieghere, hokein. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Changed two references to developers as "he" or "him" to the more neutral "they". Repository: rG LLVM Github