This revision was automatically updated to reflect the committed changes.
Closed by commit rG4ad53177db75: [LLDB] Fix overloaded operator new cases in
TestCppOperators.py which currently… (authored by shafik).
Herald added a project: LLDB.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
shafik updated this revision to Diff 261920.
shafik marked an inline comment as done.
shafik added a comment.
Removing `custom_new` since it is now unused.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79251/new/
https://reviews.llvm.org/D79251
Files:
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Comment at: lldb/test/API/lang/cpp/operators/main.cpp:12
bool custom_new = false;
B b;
This can also go as it's now unused.
shafik created this revision.
shafik added reviewers: teemperor, aprantl, labath.
The overloaded `new operator` in `TestCppOperators.py` are working by accident.
Currently we have:
void *operator new(std::size_t size) { C* r = ::new C; r->custom_new = true;
return r; }
void *operator