[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

This revision was automatically updated to reflect the committed changes. Closed by commit rG567ba6c468b9: [LLDB] Add ptrace register access for AArch64 SVE registers (authored by omjavaid). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D79699?vs=285956&id=2865

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good, just the cpuinfo detection function could use a bit of improvement. Thanks for your patience. Comment at: lldb/test/API/commands/register/register/aarch64_sve_r

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid updated this revision to Diff 285956. omjavaid added a comment. This update adds check for SVE support using /proc/cpuinfo in SVE testcases. Also tests case to read predicate registers with 5 different values instead of 0xff. @labath this seems reasonable now? CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

labath added a comment. In D79699#2215216 , @omjavaid wrote: > @labath Any further action needed on this change? I have updated test main.c > for doing asm write to SVE regs and then reading them back during testing. > Also i have removed NativeProcessLi

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid added a comment. @labath Any further action needed on this change? I have updated test main.c for doing asm write to SVE regs and then reading them back during testing. Also i have removed NativeProcessLinux_arm64 dependence on LinuxPTraceDefines_arm64sve.h. We are using sys root's pt

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid updated this revision to Diff 284328. omjavaid added a comment. This patch fixes review items from last review cycles. Now we do not use LinuxPTraceDefines_arm64sve.h for NativeProcessLinux_arm64 as these defs are already back ported into libc ptrace.h available on most distros. LLDB ar

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

labath added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.h:22 +#define INCLUDE_LINUX_PTRACE_DEFINITIONS_FOR_SVE_ARM64 +#include "Plugins/Process/Utility/LinuxPTraceDefines_arm64sve.h" +#endif omjavaid wrote: >

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid updated this revision to Diff 280373. omjavaid added a comment. In this update I have moved ConfigureRegisterContext insider InvalidateAllRegisters in light of D84501 where we move InvalidateAllRegisters on every stop rather than doing so before step/r

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid marked 3 inline comments as done. omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:240 + // Update SVE registers in case there is change in configuration. + ConfigureRegisterContext(); + ---

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

labath added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:240 + // Update SVE registers in case there is change in configuration. + ConfigureRegisterContext(); + omjavaid wrote: > labath wrote: > > What's

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid updated this revision to Diff 280037. omjavaid added a comment. This update fixes issues highlighted in last review iteration. @labath any further action on this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79699/new/ https://reviews.llvm.org/D79699 Files: lldb/source/Plu

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid marked an inline comment as done. omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.h:22 +#define INCLUDE_LINUX_PTRACE_DEFINITIONS_FOR_SVE_ARM64 +#include "Plugins/Process/Utility/LinuxPTraceDefines_arm64sve.h

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid marked 3 inline comments as done. omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:240 + // Update SVE registers in case there is change in configuration. + ConfigureRegisterContext(); + ---

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

labath added a comment. I haven't looked at all the sve details, but they seem very similar to the core file stuff, so I think they should be fine. I have some other comments though... Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:240 + /

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid updated this revision to Diff 278718. omjavaid added a comment. This revision updates SVE ptrace support to reflect changes we made in SVE core file support specially around handling of FPSR and FPCR. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79699/new/ https://reviews.llv

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid updated this revision to Diff 278127. omjavaid added a comment. Updated and re-based after changes in core file patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79699/new/ https://reviews.llvm.org/D79699 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid updated this revision to Diff 277703. omjavaid added a comment. This update makes changes to avoid dependence on lldb-arm64-register-enums.h. Also provides rebased version after update of parent patches. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79699/new/ https://reviews.

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid updated this revision to Diff 276964. omjavaid added a comment. This update incorporates suggestion from last iteration and also rebases after merger of register sets and register infos in RegisterInfosPOSIX_arm64. Also I have posted a separate patch D83541

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid updated this revision to Diff 275038. omjavaid added a comment. This update remove dependence over generic interfaces by calling ConfigureRegisterContext on every call to ReadRegister/WriteRegister. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79699/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid updated this revision to Diff 271528. omjavaid added a comment. This update remove skipping over register infos requirement by overlapping sve register numbers with debug register numbers which are not required by Linux register context. CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid updated this revision to Diff 263935. omjavaid added a comment. This new updated patch overrides GetRegisterInfoAtIndex in NativeRegisterContextLinux_arm64 to reduce the impacts of register numbering conversion on the generic LLGS code. CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

omjavaid created this revision. omjavaid added reviewers: labath, jasonmolenda, clayborg. Herald added subscribers: danielkiss, kristof.beyls, tschuett. Herald added a reviewer: rengolin. This patch adds NativeRegisterContext_arm64 ptrace routines to access AArch64 SVE registers. This patch also