[Lldb-commits] [PATCH] D79823: [lldb][Core] Remove dead codepath in Mangled

jingham added a comment. Note that there is no guarantee that ObjC names won't be mangled. They aren't on macOS because the macOS linker grew up along with objC so all the weird characters it introduces into the symbol namespace ([,],-,+, ,etc...) are allowed. Way back in the day when WebObje

[Lldb-commits] [PATCH] D79823: [lldb][Core] Remove dead codepath in Mangled

This revision was automatically updated to reflect the committed changes. Closed by commit rG1079978b3c50: [lldb][Core] Remove dead codepath in Mangled (authored by xiaobai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79823/new/ https://reviews.l

[Lldb-commits] [PATCH] D79823: [lldb][Core] Remove dead codepath in Mangled

xiaobai added a comment. In D79823#2032827 , @davide wrote: > I'm curious what happens if you end up here with something like `_T`. Did you > check? I assume you're talking about swift, which should be handled by a `SwiftLanguage` plugin. Can Objective

[Lldb-commits] [PATCH] D79823: [lldb][Core] Remove dead codepath in Mangled

davide added a comment. I'm curious what happens if you end up here with something like `_T`. Did you check? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79823/new/ https://reviews.llvm.org/D79823 __

[Lldb-commits] [PATCH] D79823: [lldb][Core] Remove dead codepath in Mangled

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Presumably. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79823/new/ https://reviews.llvm.org/D79823

[Lldb-commits] [PATCH] D79823: [lldb][Core] Remove dead codepath in Mangled

xiaobai created this revision. xiaobai added reviewers: friss, JDevlieghere, shafik. Herald added a project: LLDB. Objective-C names are stored in m_demangled, not in m_mangled. The method in the condition will never return true. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D7