[Lldb-commits] [PATCH] D80105: [LLDB] Combine multiple defs of arm64 register sets

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG7fa7b81bcbd0: Combine multiple defs of arm64 register sets (authored by omjavaid). Herald added a project: LLDB. Changed

[Lldb-commits] [PATCH] D80105: [LLDB] Combine multiple defs of arm64 register sets

This revision was automatically updated to reflect the committed changes. Closed by commit rG7fa7b81bcbd0: Combine multiple defs of arm64 register sets (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D80105: [LLDB] Combine multiple defs of arm64 register sets

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. ship it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80105/new/ https://reviews.llvm.org/D80105 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D80105: [LLDB] Combine multiple defs of arm64 register sets

omjavaid updated this revision to Diff 276015. omjavaid added a comment. This revision fixed issues highlighted in last review. LGTM? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80105/new/ https://reviews.llvm.org/D80105 Files: lldb/source/Plugins/Process/FreeBSD/FreeBSDThread.cpp

[Lldb-commits] [PATCH] D80105: [LLDB] Combine multiple defs of arm64 register sets

omjavaid marked 3 inline comments as done. omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_arm64.cpp:46 +: lldb_private::RegisterContext(thread, 0) { + m_register_info_up = std::move(register_info); lab

[Lldb-commits] [PATCH] D80105: [LLDB] Combine multiple defs of arm64 register sets

labath marked an inline comment as done. labath added a comment. This looks great. I just have a quick question about the GPR vs GPRegSet thingy... Comment at: lldb/source/Plugins/Process/FreeBSD/FreeBSDThread.cpp:167 assert(target_arch.GetTriple().getOS() == llvm::Triple

[Lldb-commits] [PATCH] D80105: [LLDB] Combine multiple defs of arm64 register sets

omjavaid updated this revision to Diff 275869. omjavaid added a comment. This new revision incorporates all suggestions on previous version. @labath What do you think? I have skipped merging switch statements and have picked all other suggestions you highlighted. If this is LGTM then i can rebas

[Lldb-commits] [PATCH] D80105: [LLDB] Combine multiple defs of arm64 register sets

omjavaid marked 10 inline comments as done. omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSD/FreeBSDThread.cpp:167 assert(target_arch.GetTriple().getOS() == llvm::Triple::FreeBSD); switch (target_arch.GetMachine()) { case llvm::Triple

[Lldb-commits] [PATCH] D80105: [LLDB] Combine multiple defs of arm64 register sets

labath added a comment. I like this. Comment at: lldb/source/Plugins/Process/FreeBSD/FreeBSDThread.cpp:167 assert(target_arch.GetTriple().getOS() == llvm::Triple::FreeBSD); switch (target_arch.GetMachine()) { case llvm::Triple::aarch64: It would

[Lldb-commits] [PATCH] D80105: [LLDB] Combine multiple defs of arm64 register sets

omjavaid updated this revision to Diff 274382. omjavaid added a comment. In this updated I have segregated RegisterInfoInterface and RegisterInfoAndSetInterface as two mutually exclusive interfaces. RegisterInfoPosix_arm64 is currently the only class making use of set interface but I am going t

[Lldb-commits] [PATCH] D80105: [LLDB] Combine multiple defs of arm64 register sets

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added subscribers: danielkiss, atanasyan, kristof.beyls, emaste. This patch aims to combine similar arm64 register set definitions defined in NativeRegisterContextLinux_arm64 and RegisterContextPOSIX_arm64. I have implement