[Lldb-commits] [PATCH] D81010: [lldb/DWARF] Fix PC value for artificial tail call frames for the "GNU" case

This revision was automatically updated to reflect the committed changes. Closed by commit rG0081149f96bd: [lldb/DWARF] Fix PC value for artificial tail call frames for the GNU case (authored by labath). Changed prior to commit: https://reviews.llvm.org/D81010?vs=268102=269191#toc Repository:

[Lldb-commits] [PATCH] D81010: [lldb/DWARF] Fix PC value for artificial tail call frames for the "GNU" case

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Lgtm. Comment at: lldb/source/Symbol/Function.cpp:321 llvm::ArrayRef> Function::GetTailCallingEdges() { // Call edges are sorted by return PC, and tail calling edges have

[Lldb-commits] [PATCH] D81010: [lldb/DWARF] Fix PC value for artificial tail call frames for the "GNU" case

labath updated this revision to Diff 268102. labath added a comment. - Unpack the CallEdge structure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81010/new/ https://reviews.llvm.org/D81010 Files: lldb/include/lldb/Symbol/Function.h

[Lldb-commits] [PATCH] D81010: [lldb/DWARF] Fix PC value for artificial tail call frames for the "GNU" case

labath marked an inline comment as done. labath added inline comments. Comment at: lldb/include/lldb/Symbol/Function.h:332 - /// The address of the call instruction. Usually an invalid address, unless - /// this is a tail call. - lldb::addr_t call_inst_pc; + bool

[Lldb-commits] [PATCH] D81010: [lldb/DWARF] Fix PC value for artificial tail call frames for the "GNU" case

vsk added a comment. Thanks, this ended up being a lot cleaner than I expected! Comment at: lldb/include/lldb/Symbol/Function.h:332 - /// The address of the call instruction. Usually an invalid address, unless - /// this is a tail call. - lldb::addr_t call_inst_pc; +

[Lldb-commits] [PATCH] D81010: [lldb/DWARF] Fix PC value for artificial tail call frames for the "GNU" case

labath created this revision. labath added reviewers: vsk, dblaikie. Herald added subscribers: mgrang, aprantl. Herald added a project: LLDB. The way that the support for the GNU dialect of tail call frames was implemented in D80519 meant that the were reporting