MaskRay added a comment.
Hi, your git commit contains extra Phabricator tags. You can drop `Reviewers:`
`Subscribers:` `Tags:` and the text `Summary:` from the git commit with the
following script:
arcfilter () {
arc amend
git log -1 --pretty=%B | awk
This revision was automatically updated to reflect the committed changes.
Closed by commit rG0a9e7d0b6bef: [vscode] set default values for
terminateDebuggee for the disconnect request (authored by Walter Erquinigo
walterme...@fb.com).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
labath accepted this revision.
labath added a comment.
Yes, this looks better, though I am mildly worried about the use of timeouts.
There probably isn't anything better we can do for the "launch" case, but we
could definitely come up with something better for the "attach" case. I think
we can
wallace updated this revision to Diff 271224.
wallace edited the summary of this revision.
wallace added a comment.
remove unwanted changes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81200/new/
https://reviews.llvm.org/D81200
Files:
wallace added a comment.
@labath , does this look better now?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81200/new/
https://reviews.llvm.org/D81200
___
lldb-commits mailing list
wallace updated this revision to Diff 270804.
wallace edited the summary of this revision.
wallace removed a reviewer: kusmour.
wallace added a comment.
The tests were weird indeed, I think I had to revisit them after making some
changes.
Anyway, I've updated the tests and they do make sense
labath added inline comments.
Comment at:
lldb/test/API/tools/lldb-vscode/disconnect/TestVSCode_disconnect.py:68
+
+self.disconnect_and_check_no_output()
labath wrote:
> I'm confused as to why we're not expecting any output here. I was under the
>
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
I'm ok with this then if the error being returned for disconnect doesn't affect
the IDE. Anyone else should chime in quickly if you have any objections.
Repository:
rG LLVM Github
wallace marked an inline comment as done.
wallace added inline comments.
Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:796
+if (!error.Success())
+ response.try_emplace("error", error.GetCString());
g_vsc.debugger.SetAsync(true);
clayborg
clayborg added inline comments.
Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:796
+if (!error.Success())
+ response.try_emplace("error", error.GetCString());
g_vsc.debugger.SetAsync(true);
I am not sure what returning an error to disconnect
wallace updated this revision to Diff 270038.
wallace added a comment.
I updated the tests and did some minor changes.
@clayborg, after some testing, I noticed that this doesn't fix the problem of
lldb-vscode instances not dying, however it solves the problem
of long-running inferiors not
labath added inline comments.
Comment at:
lldb/test/API/tools/lldb-vscode/disconnect/TestVSCode_disconnect.py:55
+
+self.process = subprocess.Popen([program, "--attach"],
+universal_newlines=True,
Writing an
wallace marked 2 inline comments as done.
wallace added a comment.
Well, the problem that i've seen happens mostly with long running processes
like services that just don't die. So this fixes those issues anyway because
those processes are not dying when they should. I tried an older version of
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
So the main question is why was lldb-vscode not exiting. Do we know why? Some
thread wasn't exiting I would guess, but usually as long as the main thread
exits, all other
wallace created this revision.
wallace added reviewers: clayborg, labath, aadsm.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
wallace added a reviewer: kusmour.
Recently I've noticed that VSCode sometimes doesn't send the terminateDebuggee
flag within the
15 matches
Mail list logo
