[Lldb-commits] [PATCH] D81499: [Debugger] Use FileSystem instead of calling llvm::sys::fs::openFileForWrite directly.

yrouban added a comment. Sorry, I have a typo in diff number. My commit relates to https://reviews.llvm.org/D81449. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81499/new/ https://reviews.llvm.org/D81499

[Lldb-commits] [PATCH] D81499: [Debugger] Use FileSystem instead of calling llvm::sys::fs::openFileForWrite directly.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b2e676555c1: [Debugger] Use FileSystem instead of calling openFileForWrite directly. (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D81499: [Debugger] Use FileSystem instead of calling llvm::sys::fs::openFileForWrite directly.

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM then. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81499/new/ https://reviews.llvm.org/D81499 ___

[Lldb-commits] [PATCH] D81499: [Debugger] Use FileSystem instead of calling llvm::sys::fs::openFileForWrite directly.

JDevlieghere added a comment. In D81499#2086268 , @jingham wrote: > This looks okay to me though I'm not very familiar with the llvm file system > interfaces. > > Do we have any tests that tests that log output gets emitted to the file > requested when

[Lldb-commits] [PATCH] D81499: [Debugger] Use FileSystem instead of calling llvm::sys::fs::openFileForWrite directly.

jingham added a comment. This looks okay to me though I'm not very familiar with the llvm file system interfaces. Do we have any tests that tests that log output gets emitted to the file requested when you do "log enable -f somefile whatever"? If so and they still work, LGTM. If we don't

[Lldb-commits] [PATCH] D81499: [Debugger] Use FileSystem instead of calling llvm::sys::fs::openFileForWrite directly.

JDevlieghere created this revision. JDevlieghere added reviewers: labath, jingham. This replaces the (only) call to `llvm::sys::fs::openFileForWrite` with `FileSystem::Open`. This guarantees that we include log files in the reproducers. Repository: rLLDB LLDB