+ Shivam (Up until today I thought this was just theoretical musing but
now I realized that there is actually some work going towards this.)
On 25/06/2020 20:45, Jim Ingham wrote:
>
> One of the things that is core functionality in the debugger is “when X
> happens, do Y”. When I stop, do
I’m not sure
> On Jun 25, 2020, at 5:08 AM, Pavel Labath wrote:
>
> On 24/06/2020 18:55, Jim Ingham wrote:
>>
>>> On Jun 22, 2020, at 5:52 AM, Pavel Labath via Phabricator via lldb-commits
>>> wrote:
>>>
>>> labath added a comment.
>>>
>>> This seems like it could be useful in some
On 24/06/2020 18:55, Jim Ingham wrote:
>
>> On Jun 22, 2020, at 5:52 AM, Pavel Labath via Phabricator via lldb-commits
>> wrote:
>>
>> labath added a comment.
>>
>> This seems like it could be useful in some circumstances, though for the use
>> cases I am imagining (bug reporting) it would be
labath added a comment.
The code looks fine to me, though it sounds like there are still issues to be
sorted out w.r.t commands run from inside data formatters, through sb apis,
etc. And it needs tests, of course.
Comment at: lldb/source/Commands/CommandObjectSession.h:22-26
mib updated this revision to Diff 273087.
mib marked 8 inline comments as done.
mib added a comment.
Addressed Pavel's and Jonas' comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82155/new/
https://reviews.llvm.org/D82155
Files:
mib updated this revision to Diff 273090.
mib added a comment.
Ran clang-format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82155/new/
https://reviews.llvm.org/D82155
Files:
lldb/include/lldb/Interpreter/CommandInterpreter.h
> On Jun 22, 2020, at 5:52 AM, Pavel Labath via Phabricator via lldb-commits
> wrote:
>
> labath added a comment.
>
> This seems like it could be useful in some circumstances, though for the use
> cases I am imagining (bug reporting) it would be easier to just copy-paste
> the terminal
labath added a comment.
This seems like it could be useful in some circumstances, though for the use
cases I am imagining (bug reporting) it would be easier to just copy-paste the
terminal contents.
As for the implementation, if the intention is for this to eventually capture
all debugger
mib marked 9 inline comments as done.
mib added inline comments.
Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2929
+ Status error;
+ user_id_t fd_dst = FileCache::GetInstance().OpenFile(
+ FileSpec(output_file), flags, lldb::eFilePermissionsFileDefault,
JDevlieghere added inline comments.
Comment at: lldb/source/Commands/CommandObjectSession.cpp:10
+public:
+ // Constructors and Destructors
+ CommandObjectSessionSave(CommandInterpreter )
Remove
Comment at:
mib added a comment.
Hey folks, this is a first implementation of the patch and surely there will be
several other revisions before landing it.
Some functionalities are not supported yet, like:
- Multi-line expression
- Python/Lua? Interactive script interpreter
- Outputs that aren't in the
mib created this revision.
mib added reviewers: labath, JDevlieghere.
mib added a project: LLDB.
Herald added a subscriber: mgorny.
mib retitled this revision from "[lldb/interpreter] Add ability to save lldb
session to a file" to "[WIP][lldb/interpreter] Add ability to save lldb session
to a
12 matches
Mail list logo
