davide closed this revision.
davide added a comment.
Somebody will pick this up, probably in a different form.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82813/new/
https://reviews.llvm.org/D82813
___
lldb-commits mailing list
lldb-commits
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
From my side this is good to go once everybody else's concerns are addressed.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82813/new/
https://reviews.llvm.org/D82813
___
aprantl added inline comments.
Comment at: lldb/include/lldb/Host/Host.h:231
+ /// Check whether a process is translated (Rosetta).
+ /// \arg process_info The info structure for the process queried.
labath wrote:
> aprantl wrote:
> > davide wrote:
> > > apra
labath added inline comments.
Comment at: lldb/include/lldb/Host/Host.h:231
+ /// Check whether a process is translated (Rosetta).
+ /// \arg process_info The info structure for the process queried.
aprantl wrote:
> davide wrote:
> > aprantl wrote:
> > > Is t
aprantl added inline comments.
Comment at: lldb/include/lldb/Host/Host.h:231
+ /// Check whether a process is translated (Rosetta).
+ /// \arg process_info The info structure for the process queried.
davide wrote:
> aprantl wrote:
> > Is this supposed to be a
davide marked an inline comment as done.
davide added inline comments.
Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:3424
+if (Host::IsProcessTranslated(process_info)) {
+ FileSpec
rosetta_debugserver("/Library/Apple/usr/libexec/oah/debugserver
labath added inline comments.
Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:3424
+if (Host::IsProcessTranslated(process_info)) {
+ FileSpec
rosetta_debugserver("/Library/Apple/usr/libexec/oah/debugserver");
+ debugserver_launch_info.SetExe
davide marked an inline comment as done.
davide added inline comments.
Comment at: lldb/include/lldb/Host/Host.h:231
+ /// Check whether a process is translated (Rosetta).
+ /// \arg process_info The info structure for the process queried.
aprantl wrote:
> Is
davide marked an inline comment as done.
davide added inline comments.
Comment at: lldb/include/lldb/Host/Host.h:231
+ /// Run a shell command.
+ /// \arg process_info The info structure for the process queried.
Stale comment, I'll update
CHANGES SINCE LAST
davide created this revision.
davide added reviewers: aprantl, jasonmolenda.
Nothing crazy here, just an organizational cleanup.
https://reviews.llvm.org/D82813
Files:
lldb/include/lldb/Host/Host.h
lldb/source/Host/common/Host.cpp
lldb/source/Host/macosx/objcxx/Host.mm
lldb/source/Plugi
davide updated this revision to Diff 274253.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82813/new/
https://reviews.llvm.org/D82813
Files:
lldb/include/lldb/Host/Host.h
lldb/source/Host/common/Host.cpp
lldb/source/Host/macosx/objcxx/Host.mm
lldb/source/Plugins/Process/gdb-remot
JDevlieghere added inline comments.
Comment at: lldb/source/Host/macosx/objcxx/Host.mm:1471
+ size_t bufsize = sizeof(processInfo);
+ if (sysctl(mib, (unsigned)(sizeof(mib)/sizeof(int)), &processInfo,
+ &bufsize, NULL, 0) == 0 && bufsize <= 0)
nit:
aprantl added inline comments.
Comment at: lldb/include/lldb/Host/Host.h:231
+ /// Check whether a process is translated (Rosetta).
+ /// \arg process_info The info structure for the process queried.
Is this supposed to be a generic function call that, e.g, s
13 matches
Mail list logo