[Lldb-commits] [PATCH] D83454: [CMake] Make `intrinsics_gen` dependency unconditional.

This revision was automatically updated to reflect the committed changes. Closed by commit rG53880b8cb9c6: [CMake] Make `intrinsics_gen` dependency unconditional. (authored by michele.scandale, committed by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D83454: [CMake] Make `intrinsics_gen` dependency unconditional.

michele.scandale added a comment. In D83454#2145086 , @michele.scandale wrote: > In D83454#2144386 , @JDevlieghere > wrote: > > > In D83454#2142719 , > >

[Lldb-commits] [PATCH] D83454: [CMake] Make `intrinsics_gen` dependency unconditional.

michele.scandale added a comment. In D83454#2144386 , @JDevlieghere wrote: > In D83454#2142719 , > @michele.scandale wrote: > > > I tested locally the standalone build of Clang with D83426 > >

[Lldb-commits] [PATCH] D83454: [CMake] Make `intrinsics_gen` dependency unconditional.

JDevlieghere added a comment. In D83454#2142719 , @michele.scandale wrote: > I tested locally the standalone build of Clang with D83426 > . > I just want to make sure that we all agree this is right way moving forward.

[Lldb-commits] [PATCH] D83454: [CMake] Make `intrinsics_gen` dependency unconditional.

michele.scandale added a comment. I tested locally the standalone build of Clang with D83426 . I just want to make sure that we all agree this is right way moving forward. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D83454: [CMake] Make `intrinsics_gen` dependency unconditional.

JDevlieghere added a comment. LGTM. I verified this works for the build-tree standalone build of LLDB, but please still keep an eye on http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-standalone/ after you land this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D83454: [CMake] Make `intrinsics_gen` dependency unconditional.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks like a good cleanup. Hope someone with more CMake-fu to confirm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83454/new/

[Lldb-commits] [PATCH] D83454: [CMake] Make `intrinsics_gen` dependency unconditional.

michele.scandale created this revision. michele.scandale added reviewers: chandlerc, beanz, zturner. Herald added subscribers: lldb-commits, cfe-commits, MaskRay, aheejin, arichardson, sbc100, mgorny, emaste. Herald added a reviewer: espindola. Herald added a reviewer: MaskRay. Herald added