[Lldb-commits] [PATCH] D83815: [lldb/Test] Use a process group for subprocesses

JDevlieghere added a comment. In D83815#2153459 , @labath wrote: > In D83815#2153438 , @JDevlieghere > wrote: > > > In D83815#2152688 , @labath wrote: > > > > > > > > > > >

[Lldb-commits] [PATCH] D83815: [lldb/Test] Use a process group for subprocesses

labath added a comment. In D83815#2153438 , @JDevlieghere wrote: > In D83815#2152688 , @labath wrote: > > > > > > Given that we were already creating a process group on fork, I'll keep the > change on line 902 tha

[Lldb-commits] [PATCH] D83815: [lldb/Test] Use a process group for subprocesses

JDevlieghere abandoned this revision. JDevlieghere added a comment. In D83815#2152688 , @labath wrote: > hmm... I have a lot thoughts here.. > > - `setsid` is overkill. If you want to create process group, create a process > group (`setpgid`), not a sessi

[Lldb-commits] [PATCH] D83815: [lldb/Test] Use a process group for subprocesses

labath added a comment. hmm... I have a lot thoughts here.. - `setsid` is overkill. If you want to create process group, create a process group (`setpgid`), not a session. - this solution does not seem very windows-friendly. In fact, I'd be surprised if it works there at all. - going for `os.ki

[Lldb-commits] [PATCH] D83815: [lldb/Test] Use a process group for subprocesses

JDevlieghere updated this revision to Diff 277989. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83815/new/ https://reviews.llvm.org/D83815 Files: lldb/packages/Python/lldbsuite/test/lldbtest.py Index: lldb/packages/Python/lldbsuite/test/lldbtest.py ==

[Lldb-commits] [PATCH] D83815: [lldb/Test] Use a process group for subprocesses

JDevlieghere added a comment. We're still seeing a lot of zombies from the test suite on the bots. I'm hoping this might get rid of one possible source. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83815/new/ https://reviews.llvm.org/D83815 ___

[Lldb-commits] [PATCH] D83815: [lldb/Test] Use a process group for subprocesses

JDevlieghere created this revision. JDevlieghere added reviewers: labath, teemperor. Herald added a subscriber: abidh. Use a process group for processes spawned by the test suite so we can send a signal to the whole group. This ensures any child processes are terminated as well. Repository: