[Lldb-commits] [PATCH] D84008: [DWARFYAML][WIP] Refactor emitDebugInfo() to make the length be inferred.

2020-07-22 Thread Xing GUO via Phabricator via lldb-commits
Higuoxing updated this revision to Diff 279756. Higuoxing added a comment. Herald added subscribers: sstefan1, ormris, emaste. Herald added a reviewer: espindola. Herald added a reviewer: jdoerfert. Address comments & Rebase & Add one test. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D84008: [DWARFYAML][WIP] Refactor emitDebugInfo() to make the length be inferred.

2020-07-20 Thread James Henderson via Phabricator via lldb-commits
jhenderson added a comment. In principle, this approach looks fine, but please do as @labath suggests to reduce the amount of changes in one go. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84008/new/ https://reviews.llvm.org/D84008

[Lldb-commits] [PATCH] D84008: [DWARFYAML][WIP] Refactor emitDebugInfo() to make the length be inferred.

2020-07-20 Thread Xing GUO via Phabricator via lldb-commits
Higuoxing added a comment. In D84008#2161461 , @labath wrote: > In D84008#2161243 , @Higuoxing wrote: > > > In D84008#2160426 , @MaskRay wrote: > > > > > The number of

[Lldb-commits] [PATCH] D84008: [DWARFYAML][WIP] Refactor emitDebugInfo() to make the length be inferred.

2020-07-20 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D84008#2161243 , @Higuoxing wrote: > In D84008#2160426 , @MaskRay wrote: > > > The number of changed tests is large. Is it worth moving the > > `IO.mapOptional("Length", Unit.Length);`

[Lldb-commits] [PATCH] D84008: [DWARFYAML][WIP] Refactor emitDebugInfo() to make the length be inferred.

2020-07-19 Thread Xing GUO via Phabricator via lldb-commits
Higuoxing added a comment. In D84008#2160426 , @MaskRay wrote: > The number of changed tests is large. Is it worth moving the > `IO.mapOptional("Length", Unit.Length);` change to a separate patch to make > the refactoring more focused? Thanks This

[Lldb-commits] [PATCH] D84008: [DWARFYAML][WIP] Refactor emitDebugInfo() to make the length be inferred.

2020-07-18 Thread Fangrui Song via Phabricator via lldb-commits
MaskRay added a comment. The number of changed tests is large. Is it worth moving the `IO.mapOptional("Length", Unit.Length);` change to a separate patch to make the refactoring more focused? Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION