This revision was automatically updated to reflect the committed changes.
Closed by commit rG85fbb08fa2ac: [lldb/interpreter] Move the history subcommand
to session (NFCI) (authored by mib).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84307/new/
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
The patch itself is fine, so let's ship it!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84307/new/
https://reviews.llvm.org/D84307
jingham added a comment.
The current lldb behavior is that when you start up lldb, it reads the editline
command-history file (so the history of the previous session), and loads it
into it's internal command history, which you can get to by up and down arrows
or ^R searches. But it doesn't
teemperor added a subscriber: jingham.
teemperor added a comment.
Isn't `session` just concerned with the *current* LLDB session? LLDB's command
history is only spanning the current session at the moment, but I always
thought that's more of a bug and not a feature (In fact one of my GSoC
teemperor added a reviewer: jingham.
teemperor removed a subscriber: jingham.
teemperor added a comment.
(Phab send the whole thing when I pressed enter)
I added Jim who might have more insights on the design rationale here, but IMHO
this seems like an improvement.
Repository:
rG LLVM
labath added a comment.
I don't have any strong opinions about this either way. The `history` alias is
kind of nice because it matches the bash builtin, but I don't use either of
them often enough to care.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
mib created this revision.
mib added reviewers: labath, teemperor.
mib added a project: LLDB.
Herald added a subscriber: lldb-commits.
This patch moves the `history` subcommand from the `command` to `session`.
I think it makes more sense to have it there because as the `command` usage
suggests,
