[Lldb-commits] [PATCH] D84527: Rename StoppointLocation to StoppointSite and drop its relationship with BreakpointLocation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGda0bba5c9abb: [lldb/Breakpoint] Rename StoppointLocation to StoppointSite and drop its… (authored by tatyana-krasnukha). Changed prior to commit:

[Lldb-commits] [PATCH] D84527: Rename StoppointLocation to StoppointSite and drop its relationship with BreakpointLocation

jingham accepted this revision. jingham added a comment. Remember to do the action thingie... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84527/new/ https://reviews.llvm.org/D84527 ___ lldb-commits mai

[Lldb-commits] [PATCH] D84527: Rename StoppointLocation to StoppointSite and drop its relationship with BreakpointLocation

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84527/new/ https://reviews.llvm.org/D84527 _

[Lldb-commits] [PATCH] D84527: Rename StoppointLocation to StoppointSite and drop its relationship with BreakpointLocation

tatyana-krasnukha updated this revision to Diff 281600. tatyana-krasnukha added reviewers: JDevlieghere, jingham. tatyana-krasnukha added a comment. Addressed comments. > It's also a little weird that we're clearing watchpoint hit counts when a > process dies, but not breakpoint hit counts. If w

[Lldb-commits] [PATCH] D84527: Rename StoppointLocation to StoppointSite and drop its relationship with BreakpointLocation

jingham added a comment. This overall change makes sense to me. It seems a little awkward that Target has to know that Watchpoints have a m_hit_counter. It's also a little weird that we're clearing watchpoint hit counts when a process dies, but not breakpoint hit counts. If we do one we shou

[Lldb-commits] [PATCH] D84527: Rename StoppointLocation to StoppointSite and drop its relationship with BreakpointLocation

JDevlieghere added a comment. Some nits but overall this looks good. Comment at: lldb/include/lldb/Breakpoint/Breakpoint.h:657 bool m_resolve_indirect_symbols; - uint32_t m_hit_count; // Number of times this breakpoint/watchpoint has been -// hit. T

[Lldb-commits] [PATCH] D84527: Rename StoppointLocation to StoppointSite and drop its relationship with BreakpointLocation

tatyana-krasnukha created this revision. Herald added subscribers: lldb-commits, yaxunl, mgorny. Herald added a project: LLDB. Working on the patch D84257 I noticed that both BreakpointLocation and BreakpointSite were inherited from StoppointLocation. Also, I n