[Lldb-commits] [PATCH] D87441: Speedup collecting DWARF attribute values

2020-09-15 Thread Dmitry Antipov via Phabricator via lldb-commits
dmantipov abandoned this revision. dmantipov added a comment. Superseded with https://reviews.llvm.org/D87675. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87441/new/ https://reviews.llvm.org/D87441

[Lldb-commits] [PATCH] D87441: Speedup collecting DWARF attribute values

2020-09-14 Thread Dmitry Antipov via Phabricator via lldb-commits
dmantipov updated this revision to Diff 291519. dmantipov added a comment. Drop prefixes and tweak the style to match clang-format requirements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87441/new/ https://reviews.llvm.org/D87441 Files:

[Lldb-commits] [PATCH] D87441: Speedup collecting DWARF attribute values

2020-09-13 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFAttribute.h:83 + +AttributeValue(const DWARFUnit *_cu, dw_offset_t _die_offset, + dw_attr_t _attr, dw_form_t _form) aprantl wrote: > We usually don't prefix

[Lldb-commits] [PATCH] D87441: Speedup collecting DWARF attribute values

2020-09-11 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFAttribute.h:83 + +AttributeValue(const DWARFUnit *_cu, dw_offset_t _die_offset, + dw_attr_t _attr, dw_form_t _form) We usually don't prefix constructor

[Lldb-commits] [PATCH] D87441: Speedup collecting DWARF attribute values

2020-09-10 Thread Dmitry Antipov via Phabricator via lldb-commits
dmantipov created this revision. dmantipov added reviewers: labath, jankratochvil. dmantipov added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere, aprantl. dmantipov requested review of this revision. Try to speedup collecting DWARF attribute values by using emplace_back()