[Lldb-commits] [PATCH] D87442: [lldb][AArch64/Linux] Show memory tagged memory regions

2020-11-20 Thread David Spickett via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG32541685b2a9: [lldb][AArch64/Linux] Show memory tagged memory regions (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D87442: [lldb][AArch64/Linux] Show memory tagged memory regions

2020-11-20 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added a comment. I'm going to stick with the test format as it is. No doubt I'll need to clean it up based on what future MTE tests look like. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87442/new/ https://reviews.llvm.org/D87442

[Lldb-commits] [PATCH] D87442: [lldb][AArch64/Linux] Show memory tagged memory regions

2020-11-20 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D87442#2405681 , @DavidSpickett wrote: > - Use assertIn > - Cleanup Status/Error handling > - Refactor test so it runs once and we skip based on

[Lldb-commits] [PATCH] D87442: [lldb][AArch64/Linux] Show memory tagged memory regions

2020-11-19 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett updated this revision to Diff 306406. DavidSpickett added a comment. - Use assertIn - Cleanup Status/Error handling - Refactor test so it runs once and we skip based on whether it returns a value or hits a breakpoint. - Seperated exit codes for non MTE toolchain and non MTE target,

[Lldb-commits] [PATCH] D87442: [lldb][AArch64/Linux] Show memory tagged memory regions

2020-11-19 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Hopefully last round of cosmetic fixes, and then this should be good. Comment at: lldb/include/lldb/Target/MemoryRegionInfo.h:15 #include "lldb/Utility/RangeMap.h" +#include "llvm/ADT/StringRef.h" #include "llvm/Support/FormatProviders.h"