This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG92d42b32a9b7: Utility: ignore OS version on non-Darwin
targets in `ArchSpec` (authored by compnerd).
Repository:
rG LLVM Github Monorepo
CHANGES
kastiglione accepted this revision.
kastiglione added a comment.
sgtm
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88181/new/
https://reviews.llvm.org/D88181
___
lldb-commits mailing list
compnerd added a comment.
Correct, this is just upstreaming the original ArchSpec change that we found on
Swift.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88181/new/
https://reviews.llvm.org/D88181
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
This is the same change as we did on Github, right? If so this LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88181/new/
compnerd created this revision.
compnerd added reviewers: JDevlieghere, kastiglione.
compnerd added a project: LLDB.
compnerd requested review of this revision.
The OS version field is generally not very helpful for non-Darwin
targets. On Linux, it identifies the kernel version which moves