This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG71cf97e95b8c: Reland [lldb] Dont send invalid
region addresses to lldb server (authored by DavidSpickett).
Repository:
rG LLVM Github Monorepo
labath accepted this revision.
labath added a comment.
Thanks for tracking this down.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88229/new/
https://reviews.llvm.org/D88229
___
lldb-commits mailing
stella.stamenova accepted this revision.
stella.stamenova added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88229/new/
https://reviews.llvm.org/D88229
DavidSpickett updated this revision to Diff 294272.
DavidSpickett added a comment.
- clang-format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88229/new/
https://reviews.llvm.org/D88229
Files:
lldb/source/Commands/CommandObjectMemory.cpp
DavidSpickett added inline comments.
Comment at: lldb/source/Commands/CommandObjectMemory.cpp:1701
} else {
if (command.GetArgumentCount() == 1) {
auto load_addr_str = command[0].ref();
stella.stamenova wrote:
> Actually, I would
DavidSpickett updated this revision to Diff 294266.
DavidSpickett added a comment.
- Convert memory region to early return style to make the logic clearer
- Only call ::GetLastError once when VirtualQueryEx fails
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
stella.stamenova added inline comments.
Comment at: lldb/source/Commands/CommandObjectMemory.cpp:1701
} else {
if (command.GetArgumentCount() == 1) {
auto load_addr_str = command[0].ref();
Actually, I would change the logic here a
DavidSpickett added a reviewer: labath.
DavidSpickett added a comment.
This is probably pretty trivial but my first dive into win32 stuff so wanted to
double check my logic before relanding.
References:
https://docs.microsoft.com/en-us/windows/win32/api/memoryapi/nf-memoryapi-virtualqueryex
DavidSpickett created this revision.
Herald added a reviewer: JDevlieghere.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
DavidSpickett requested review of this revision.
This reverts commit c65627a1fe3be7521fc232d633bb6df577f55269
