[Lldb-commits] [PATCH] D88728: [lldb] Check for and use ptsname_r if available

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3dfb94986170: [lldb] Check for and use ptsname_r if available (authored by labath). Changed prior to commit:

[Lldb-commits] [PATCH] D88728: [lldb] Check for and use ptsname_r if available

labath added a comment. In D88728#2315648 , @MaskRay wrote: > LGTM. Worth mentioning that this will be in POSIX issue 8 > https://www.austingroupbugs.net/bug_view_page.php?bug_id=508 Oh, cool. I didn't know posix is still being worked on :P

[Lldb-commits] [PATCH] D88728: [lldb] Check for and use ptsname_r if available

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Worth mentioning that this will be in POSIX issue 8 https://www.austingroupbugs.net/bug_view_page.php?bug_id=508 Comment at:

[Lldb-commits] [PATCH] D88728: [lldb] Check for and use ptsname_r if available

labath added inline comments. Comment at: lldb/source/Host/common/PseudoTerminal.cpp:149 + int r = ptsname_r(m_primary_fd, buf, sizeof(buf)); + assert(r == 0); + return buf; MaskRay wrote: > MaskRay wrote: > > labath wrote: > > > mgorny wrote: > > > > labath

[Lldb-commits] [PATCH] D88728: [lldb] Check for and use ptsname_r if available

MaskRay added inline comments. Comment at: lldb/source/Host/common/PseudoTerminal.cpp:149 + int r = ptsname_r(m_primary_fd, buf, sizeof(buf)); + assert(r == 0); + return buf; MaskRay wrote: > labath wrote: > > mgorny wrote: > > > labath wrote: > > > > mgorny

[Lldb-commits] [PATCH] D88728: [lldb] Check for and use ptsname_r if available

MaskRay added inline comments. Comment at: lldb/source/Host/common/PseudoTerminal.cpp:149 + int r = ptsname_r(m_primary_fd, buf, sizeof(buf)); + assert(r == 0); + return buf; labath wrote: > mgorny wrote: > > labath wrote: > > > mgorny wrote: > > > > I would

[Lldb-commits] [PATCH] D88728: [lldb] Check for and use ptsname_r if available

labath added inline comments. Comment at: lldb/source/Host/common/PseudoTerminal.cpp:149 + int r = ptsname_r(m_primary_fd, buf, sizeof(buf)); + assert(r == 0); + return buf; mgorny wrote: > labath wrote: > > mgorny wrote: > > > I would really feel better with

[Lldb-commits] [PATCH] D88728: [lldb] Check for and use ptsname_r if available

mgorny added inline comments. Comment at: lldb/source/Host/common/PseudoTerminal.cpp:149 + int r = ptsname_r(m_primary_fd, buf, sizeof(buf)); + assert(r == 0); + return buf; labath wrote: > mgorny wrote: > > I would really feel better with a real error

[Lldb-commits] [PATCH] D88728: [lldb] Check for and use ptsname_r if available

labath added inline comments. Comment at: lldb/source/Host/common/PseudoTerminal.cpp:149 + int r = ptsname_r(m_primary_fd, buf, sizeof(buf)); + assert(r == 0); + return buf; mgorny wrote: > I would really feel better with a real error handling here. It

[Lldb-commits] [PATCH] D88728: [lldb] Check for and use ptsname_r if available

mgorny added inline comments. Comment at: lldb/source/Host/common/PseudoTerminal.cpp:149 + int r = ptsname_r(m_primary_fd, buf, sizeof(buf)); + assert(r == 0); + return buf; I would really feel better with a real error handling here. It shouldn't be hard to

[Lldb-commits] [PATCH] D88728: [lldb] Check for and use ptsname_r if available

labath created this revision. labath added reviewers: mgorny, MaskRay. Herald added a subscriber: emaste. Herald added a project: LLDB. labath requested review of this revision. Herald added a subscriber: JDevlieghere. ptsname is not thread-safe. ptsname_r is available on most (but not all)