[Lldb-commits] [PATCH] D91293: [lldb] [Process/FreeBSDRemote] Modernize and simplify YMM logic

This revision was automatically updated to reflect the committed changes. Closed by commit rG68ca01eb50af: [lldb] [Process/FreeBSDRemote] Modernize and simplify YMM logic (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D91293: [lldb] [Process/FreeBSDRemote] Modernize and simplify YMM logic

mgorny updated this revision to Diff 305158. mgorny added a comment. Rename AVX/MPX regsets to avoid matching strings in `commands/register/register/register_command/TestRegisters.py` that cause the test to wrongly assume that I have MPX on this machine. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D91293: [lldb] [Process/FreeBSDRemote] Modernize and simplify YMM logic

mgorny updated this revision to Diff 305132. mgorny added a comment. Move `YMMSplitPtr` inside the class. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91293/new/ https://reviews.llvm.org/D91293 Files:

[Lldb-commits] [PATCH] D91293: [lldb] [Process/FreeBSDRemote] Modernize and simplify YMM logic

mgorny updated this revision to Diff 305130. mgorny added a comment. Restore old register set indices, to unbreak output. (Note: I'm going to make that struct move soonish) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91293/new/ https://reviews.llvm.org/D91293 Files:

[Lldb-commits] [PATCH] D91293: [lldb] [Process/FreeBSDRemote] Modernize and simplify YMM logic

mgorny added a comment. In D91293#2393803 , @labath wrote: > In D91293#2393764 , @mgorny wrote: > >> Perform offsetting in `GetOffsetRegSetData()` to avoid UB. > > Shouldn't have the last update gone to D91411 >

[Lldb-commits] [PATCH] D91293: [lldb] [Process/FreeBSDRemote] Modernize and simplify YMM logic

mgorny updated this revision to Diff 305125. mgorny added a comment. Upload the correct diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91293/new/ https://reviews.llvm.org/D91293 Files: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp

[Lldb-commits] [PATCH] D91293: [lldb] [Process/FreeBSDRemote] Modernize and simplify YMM logic

labath added a comment. In D91293#2393764 , @mgorny wrote: > Perform offsetting in `GetOffsetRegSetData()` to avoid UB. Shouldn't have the last update gone to D91411 instead ? CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D91293: [lldb] [Process/FreeBSDRemote] Modernize and simplify YMM logic

mgorny updated this revision to Diff 305113. mgorny added a comment. Perform offsetting in `GetOffsetRegSetData()` to avoid UB. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91293/new/ https://reviews.llvm.org/D91293 Files:

[Lldb-commits] [PATCH] D91293: [lldb] [Process/FreeBSDRemote] Modernize and simplify YMM logic

mgorny updated this revision to Diff 305090. mgorny added a comment. Split LLDB-visible regsets into separate AVX and MPX. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91293/new/ https://reviews.llvm.org/D91293 Files:

[Lldb-commits] [PATCH] D91293: [lldb] [Process/FreeBSDRemote] Modernize and simplify YMM logic

labath accepted this revision. labath added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp:615 + if (offset == LLDB_INVALID_XSAVE_OFFSET) +return false; + mgorny wrote: > labath wrote: > >

[Lldb-commits] [PATCH] D91293: [lldb] [Process/FreeBSDRemote] Modernize and simplify YMM logic

mgorny updated this revision to Diff 304990. mgorny added a comment. Use a `struct`-based return type. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91293/new/ https://reviews.llvm.org/D91293 Files: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp

[Lldb-commits] [PATCH] D91293: [lldb] [Process/FreeBSDRemote] Modernize and simplify YMM logic

mgorny updated this revision to Diff 304865. mgorny added a comment. Changed prototype to use pointer referenec. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91293/new/ https://reviews.llvm.org/D91293 Files:

[Lldb-commits] [PATCH] D91293: [lldb] [Process/FreeBSDRemote] Modernize and simplify YMM logic

labath added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.h:83 size_t GetDBROffset() const; + bool GetYMMSplitReg(uint32_t reg, void **xmm, void **ymm_hi); }; mgorny wrote: > labath wrote: > >

[Lldb-commits] [PATCH] D91293: [lldb] [Process/FreeBSDRemote] Modernize and simplify YMM logic

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp:615 + if (offset == LLDB_INVALID_XSAVE_OFFSET) +return false; + labath wrote: > When does this return false? When the ymm regs are

[Lldb-commits] [PATCH] D91293: [lldb] [Process/FreeBSDRemote] Modernize and simplify YMM logic

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp:615 + if (offset == LLDB_INVALID_XSAVE_OFFSET) +return false; +

[Lldb-commits] [PATCH] D91293: [lldb] [Process/FreeBSDRemote] Modernize and simplify YMM logic

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. mgorny requested review of this revision. Eliminate the remaining swith-case code for register getters, and migrate YMM registers to regset-oriented model. Since these registers are recombined from XMM and