[Lldb-commits] [PATCH] D91835: [lldb] Add Python bindings to print stack traces on crashes.

2022-04-07 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/source/API/SBDebugger.cpp:215-216 + llvm::EnablePrettyStackTrace(); + // We don't have a meaningful argv[0] to use, so use "SBDebugger" as a + // substitute. + llvm::sys::PrintStackTraceOnErrorSignal("SBDebugger");

[Lldb-commits] [PATCH] D91835: [lldb] Add Python bindings to print stack traces on crashes.

2022-04-07 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGee2d9b872356: [lldb] Add Python bindings to print stack traces on crashes. (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D91835: [lldb] Add Python bindings to print stack traces on crashes.

2022-04-07 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor accepted this revision. teemperor added a comment. This is beautiful CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91835/new/ https://reviews.llvm.org/D91835 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D91835: [lldb] Add Python bindings to print stack traces on crashes.

2022-04-07 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. Pretty straightforward, LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91835/new/ https://reviews.llvm.org/D91835 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D91835: [lldb] Add Python bindings to print stack traces on crashes.

2022-04-07 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 421256. JDevlieghere added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91835/new/ https://reviews.llvm.org/D91835 Files: lldb/bindings/interface/SBDebugger.i lldb/include/lldb/API/SBDebugger.h

[Lldb-commits] [PATCH] D91835: [lldb] Add Python bindings to print stack traces on crashes.

2020-11-25 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In D91835#2407492 , @labath wrote: > In D91835#2407060 , @rupprecht wrote: > >> I ran manual tests for this, but I did so by introducing an intentional >> crash in a place that

[Lldb-commits] [PATCH] D91835: [lldb] Add Python bindings to print stack traces on crashes.

2020-11-20 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D91835#2407060 , @rupprecht wrote: > I ran manual tests for this, but I did so by introducing an intentional crash > in a place that obviously can't be checked in. Does LLDB have any kind of > intentional-crash-for-test

[Lldb-commits] [PATCH] D91835: [lldb] Add Python bindings to print stack traces on crashes.

2020-11-19 Thread Jordan Rupprecht via Phabricator via lldb-commits
rupprecht added a comment. I ran manual tests for this, but I did so by introducing an intentional crash in a place that obviously can't be checked in. Does LLDB have any kind of intentional-crash-for-test mechanism that could be used for a test? Also, I picked `SBDebugger` for this as it

[Lldb-commits] [PATCH] D91835: [lldb] Add Python bindings to print stack traces on crashes.

2020-11-19 Thread Jordan Rupprecht via Phabricator via lldb-commits
rupprecht created this revision. rupprecht added reviewers: teemperor, JDevlieghere, labath, vsk. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. rupprecht requested review of this revision. As noticed in D87637 , when LLDB crashes, we only