[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation (make restart) and inline archive rule to the only test

teemperor added a comment. Not sure why we even run the DSYM variant if the test disables building DSYM. I just made this a no-debug-info-test in 060b51e0524aed6b6cc452baa8eb6d663a580eee which gets it running again on the

[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation (make restart) and inline archive rule to the only test

teemperor added a comment. This is breaking the ` functionalities/archives/TestBSDArchives.py` test on macOS. It seems the MAKE_DSYM flag somehow looses its effect when the dsym version of the test is running (and then we fail generating a dsym without input files):

[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation (make restart) and inline archive rule to the only test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6afdf13ae4cc: Makefile.rules: Avoid redundant .d generation (make restart) and inline archive… (authored by MaskRay). Repository: rG LLVM Github

[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation (make restart) and inline archive rule to the only test

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94890/new/ https://reviews.llvm.org/D94890 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation (make restart) and inline archive rule to the only test

MaskRay updated this revision to Diff 318011. MaskRay marked an inline comment as done. MaskRay added a comment. $(RM) a.o b.o Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94890/new/ https://reviews.llvm.org/D94890 Files:

[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation (make restart) and inline archive rule to the only test

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with the inline comment addressed. Comment at: lldb/test/API/functionalities/archives/Makefile:11 +libfoo.a: a.o b.o + $(AR) $(ARFLAGS) $@ $^

[Lldb-commits] [PATCH] D94890: Makefile.rules: Avoid redundant .d generation (make restart) and inline archive rule to the only test

MaskRay updated this revision to Diff 317985. MaskRay retitled this revision from "Makefile.rules: Avoid redundant .d generation and make restart" to "Makefile.rules: Avoid redundant .d generation (make restart) and inline archive rule to the only test". MaskRay edited the summary of this