[Lldb-commits] [lldb] [lldb] Be conversative about setting highmem address masks (PR #90533)

https://github.com/DavidSpickett approved this pull request. https://github.com/llvm/llvm-project/pull/90533 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Be conversative about setting highmem address masks (PR #90533)

DavidSpickett wrote: Seems logical to me, keep the 99% use case simple and folks who know they need a high mem mask have to put in the extra effort to really consider it. https://github.com/llvm/llvm-project/pull/90533 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb] Be conversative about setting highmem address masks (PR #90533)

jasonmolenda wrote: > On the face of it > > > When we have an unset high memory address mask, and we are told to set low- > > and high-memory to the same new address mask, maintain the high memory mask > > as unset in Process. The same thing is done with the > > SBProcess::SetAddressMask API

[Lldb-commits] [lldb] [lldb] Be conversative about setting highmem address masks (PR #90533)

@@ -1465,6 +1465,20 @@ class Process : public std::enable_shared_from_this, /// platforms where there is a difference (only Arm Thumb at this time). lldb::addr_t FixAnyAddress(lldb::addr_t pc); + /// Retrieve the actual address masks for high memory code/data, + ///

[Lldb-commits] [lldb] [lldb] Be conversative about setting highmem address masks (PR #90533)

@@ -1465,6 +1465,20 @@ class Process : public std::enable_shared_from_this, /// platforms where there is a difference (only Arm Thumb at this time). lldb::addr_t FixAnyAddress(lldb::addr_t pc); + /// Retrieve the actual address masks for high memory code/data, + ///

[Lldb-commits] [lldb] [lldb] Be conversative about setting highmem address masks (PR #90533)

DavidSpickett wrote: On the face of it > When we have an unset high memory address mask, and we are told to set low- > and high-memory to the same new address mask, maintain the high memory mask > as unset in Process. The same thing is done with the > SBProcess::SetAddressMask API when the

[Lldb-commits] [lldb] [lldb] Be conversative about setting highmem address masks (PR #90533)

@@ -1465,6 +1465,20 @@ class Process : public std::enable_shared_from_this, /// platforms where there is a difference (only Arm Thumb at this time). lldb::addr_t FixAnyAddress(lldb::addr_t pc); + /// Retrieve the actual address masks for high memory code/data, + ///

[Lldb-commits] [lldb] [lldb] Be conversative about setting highmem address masks (PR #90533)

https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/90533 >From 3c272e99326a287f0a61c1f8c2c7ee790e1aeb48 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Mon, 29 Apr 2024 16:45:36 -0700 Subject: [PATCH 1/2] [lldb] Be conversative about setting highmem address

[Lldb-commits] [lldb] [lldb] Be conversative about setting highmem address masks (PR #90533)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes The most common case with address masks/addressable bits is that we have one value/mask that applies across the entire address space, for code and data. On AArch64, we can have separate masks for high

[Lldb-commits] [lldb] [lldb] Be conversative about setting highmem address masks (PR #90533)

https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/90533 The most common case with address masks/addressable bits is that we have one value/mask that applies across the entire address space, for code and data. On AArch64, we can have separate masks for high and