Somehow your mail is missing examples after the ‘… like:’ but the method is
named similar to the GetType* methods directly below it. Don’t really have an
opinion about whether this should be GetType* or GetCompilerType* (though I
wouldn’t add the ‘As’ to it though as that’s usually used for
Instead of GetType(...) I think GetCompilerType(…) is better or maybe even
GetAsCompilerType(…). It adds a bit more context, we have so many types. It
also feels a bit more consistent with methods like:
> On Jan 2, 2020, at 2:55 AM, Raphael Isemann via lldb-commits
> wrote:
>
>
> Author:
Author: Raphael Isemann
Date: 2020-01-02T11:54:45+01:00
New Revision: fe8e25a48a2a0f8f508499ba950181dba3d600b0
URL:
https://github.com/llvm/llvm-project/commit/fe8e25a48a2a0f8f508499ba950181dba3d600b0
DIFF:
