Re: [Lldb-commits] [lldb] r252583 - The other half of a change made by Enrico for trying to get a correct

2015-11-10 Thread Todd Fiala via lldb-commits
Yeah, we can get some gtests in for this. I'll tail back on it. It'll be a bit before I can put cycles on it but it's on my list. On Mon, Nov 9, 2015 at 9:46 PM, Zachary Turner wrote: > This is really the kind of thing that would be good to write a unit test > for. There's a lot of institutio

Re: [Lldb-commits] [lldb] r252583 - The other half of a change made by Enrico for trying to get a correct

2015-11-09 Thread Zachary Turner via lldb-commits
This is really the kind of thing that would be good to write a unit test for. There's a lot of institutional knowledge hidden away in these kinds of deep low level stuff, and a unit test is good documentation for it. I suspect this is almost guaranteed to break at some point in the future without

[Lldb-commits] [lldb] r252583 - The other half of a change made by Enrico for trying to get a correct

2015-11-09 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Nov 9 22:11:37 2015 New Revision: 252583 URL: http://llvm.org/viewvc/llvm-project?rev=252583&view=rev Log: The other half of a change made by Enrico for trying to get a correct triple for a process. He writes, "Changes to the way setting the triple works on a target so