Re: [Lldb-commits] [lldb] r282683 - Add a unit test for an x86_64 assembly inspection of

2016-09-30 Thread Jason Molenda via lldb-commits
Thanks for the help! It took me most of yesterday to get gcc-4.9 built (it's been more than a decade since I've built gcc) - I think I've got it set up now, so I'll figure this out today. I'm in the middle of looking into a bug in the 32-bit assembly assembly instruction unwind plan creation

Re: [Lldb-commits] [lldb] r282683 - Add a unit test for an x86_64 assembly inspection of

2016-09-30 Thread Pavel Labath via lldb-commits
I made a quick investigation today. The problem is indeed specific to gcc-4.9. The main differences I could see is that gcc-4.9 generates a different prologue for the function, and uses pushl for argument passing. This confuses the emulator/augmenter and the unwind information at some points ends

Re: [Lldb-commits] [lldb] r282683 - Add a unit test for an x86_64 assembly inspection of

2016-09-29 Thread Jason Molenda via lldb-commits
Yep, will do. I saw that build bot result last night and ran the testsuite on my local ubuntu box and didn't repo the failure so I thought maybe it was an already-failing test case that the bot was just telling me about. But I think I was running the test x86_64 - I'll figure out how to run

Re: [Lldb-commits] [lldb] r282683 - Add a unit test for an x86_64 assembly inspection of

2016-09-29 Thread Pavel Labath via lldb-commits
Note that the test fails when using gcc as a compiler (specifically gcc-4.9 in this case, but hopefully the exact version does not matter here). Jason, will you be able to check this out today? On 29 September 2016 at 05:45, Dimitar Vlahovski via lldb-commits < lldb-commits@lists.llvm.org>

Re: [Lldb-commits] [lldb] r282683 - Add a unit test for an x86_64 assembly inspection of

2016-09-29 Thread Dimitar Vlahovski via lldb-commits
This is the first build that failed right after your CL: http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/20083 On Thu, Sep 29, 2016 at 1:35 PM, Dimitar Vlahovski wrote: > Hi, > > Is the work that you are currently doing the reason why the lldb

Re: [Lldb-commits] [lldb] r282683 - Add a unit test for an x86_64 assembly inspection of

2016-09-29 Thread Dimitar Vlahovski via lldb-commits
Hi, Is the work that you are currently doing the reason why the lldb build on i386 is failing? http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/20099 Dimitar On Thu, Sep 29, 2016 at 5:30 AM, Jason Molenda

Re: [Lldb-commits] [lldb] r282683 - Add a unit test for an x86_64 assembly inspection of

2016-09-28 Thread Jason Molenda via lldb-commits
Good suggestions, thanks. I'll fix those when I commit the 32-bit version of the same test. J > On Sep 28, 2016, at 9:28 PM, Zachary Turner wrote: > > > > On Wed, Sep 28, 2016 at 9:10 PM Jason Molenda via lldb-commits > wrote: > > +

Re: [Lldb-commits] [lldb] r282683 - Add a unit test for an x86_64 assembly inspection of

2016-09-28 Thread Zachary Turner via lldb-commits
On Wed, Sep 28, 2016 at 9:10 PM Jason Molenda via lldb-commits < lldb-commits@lists.llvm.org> wrote: > > + EXPECT_TRUE(regloc.GetOffset() == -8); > This should be EXPECT_EQ(-8, regloc.GetOffset()); That way if it fails, you'll get a handy error message that says: Expected: -8 Actual: -7 If

[Lldb-commits] [lldb] r282683 - Add a unit test for an x86_64 assembly inspection of

2016-09-28 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed Sep 28 23:01:43 2016 New Revision: 282683 URL: http://llvm.org/viewvc/llvm-project?rev=282683=rev Log: Add a unit test for an x86_64 assembly inspection of a large stack frame with lots of spilled registers. While writing the i386 version of this test, it looks like I