Re: [Lldb-commits] [lldb] r288386 - Handle UTF-16 and UTF-32 constant CFStrings

2016-12-01 Thread Tim Hammerquist via lldb-commits
Thanks, Sean! On Thu, Dec 1, 2016 at 11:25 AM, Sean Callanan wrote: > $ svn commit > Sendingsource/Plugins/ExpressionParser/Clang/IRForTarget.cpp > Transmitting file data .done > Committing transaction... > Committed revision 288403. > > Sorry for the noise, folks.

Re: [Lldb-commits] [lldb] r288386 - Handle UTF-16 and UTF-32 constant CFStrings

2016-12-01 Thread Sean Callanan via lldb-commits
$ svn commit Sendingsource/Plugins/ExpressionParser/Clang/IRForTarget.cpp Transmitting file data .done Committing transaction... Committed revision 288403. Sorry for the noise, folks. Sean > On Dec 1, 2016, at 11:21 AM, Sean Callanan wrote: > > It'll be a fix.

Re: [Lldb-commits] [lldb] r288386 - Handle UTF-16 and UTF-32 constant CFStrings

2016-12-01 Thread Sean Callanan via lldb-commits
It'll be a fix. ETA 10 minutes. > On Dec 1, 2016, at 11:16 AM, Sean Callanan via lldb-commits > wrote: > > It's definitely this one. I'll have a fix or a revert in the next 30 minutes. >> On Dec 1, 2016, at 10:58 AM, Tim Hammerquist >

Re: [Lldb-commits] [lldb] r288386 - Handle UTF-16 and UTF-32 constant CFStrings

2016-12-01 Thread Sean Callanan via lldb-commits
It's definitely this one. I'll have a fix or a revert in the next 30 minutes. > On Dec 1, 2016, at 10:58 AM, Tim Hammerquist wrote: > > Builds with this patch have been failing due to a segfaulting testcase. See: > >

Re: [Lldb-commits] [lldb] r288386 - Handle UTF-16 and UTF-32 constant CFStrings

2016-12-01 Thread Tim Hammerquist via lldb-commits
Builds with this patch have been failing due to a segfaulting testcase. See: http://lab.llvm.org:8080/green/view/LLDB/job/lldb_build_test/22721/ http://lab.llvm.org:8080/green/view/LLDB/job/lldb_build_test/22722/ At first glance, it's possible the failure was introduced by either this commit

[Lldb-commits] [lldb] r288386 - Handle UTF-16 and UTF-32 constant CFStrings

2016-12-01 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Thu Dec 1 11:46:51 2016 New Revision: 288386 URL: http://llvm.org/viewvc/llvm-project?rev=288386=rev Log: Handle UTF-16 and UTF-32 constant CFStrings We have a longstanding issue where the expression parser does not handle wide CFStrings (e.g., @"凸凹") correctly, producing