Re: [Lldb-commits] [lldb] r319840 - [CMake] Use PRIVATE in target_link_libraries for executables

2017-12-05 Thread Zachary Turner via lldb-commits
<smee...@fb.com> > *Cc: *"lldb-commits@lists.llvm.org" <lldb-commits@lists.llvm.org> > *Subject: *Re: [Lldb-commits] [lldb] r319840 - [CMake] Use PRIVATE in > target_link_libraries for executables > > > > Oh come now, we have cross-compilation ;-)

Re: [Lldb-commits] [lldb] r319840 - [CMake] Use PRIVATE in target_link_libraries for executables

2017-12-05 Thread Shoaib Meenai via lldb-commits
gle.com>> Date: Tuesday, December 5, 2017 at 2:07 PM To: Shoaib Meenai <smee...@fb.com<mailto:smee...@fb.com>> Cc: "lldb-commits@lists.llvm.org<mailto:lldb-commits@lists.llvm.org>" <lldb-commits@lists.llvm.org<mailto:lldb-commits@lists.llvm.org>>

Re: [Lldb-commits] [lldb] r319840 - [CMake] Use PRIVATE in target_link_libraries for executables

2017-12-05 Thread Zachary Turner via lldb-commits
*To: *Shoaib Meenai <smee...@fb.com> > *Cc: *"lldb-commits@lists.llvm.org" <lldb-commits@lists.llvm.org> > *Subject: *Re: [Lldb-commits] [lldb] r319840 - [CMake] Use PRIVATE in > target_link_libraries for executables > > > > Can you / did you try this on Wind

Re: [Lldb-commits] [lldb] r319840 - [CMake] Use PRIVATE in target_link_libraries for executables

2017-12-05 Thread Shoaib Meenai via lldb-commits
uesday, December 5, 2017 at 2:07 PM To: Shoaib Meenai <smee...@fb.com> Cc: "lldb-commits@lists.llvm.org" <lldb-commits@lists.llvm.org> Subject: Re: [Lldb-commits] [lldb] r319840 - [CMake] Use PRIVATE in target_link_libraries for executables Can you / did you try this on Windows?

Re: [Lldb-commits] [lldb] r319840 - [CMake] Use PRIVATE in target_link_libraries for executables

2017-12-05 Thread Zachary Turner via lldb-commits
Can you / did you try this on Windows? I don't see any reason why it wouldn't work, but I remember having difficulty with all this CMake some time ago. On Tue, Dec 5, 2017 at 1:50 PM Shoaib Meenai via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: smeenai > Date: Tue Dec 5

[Lldb-commits] [lldb] r319840 - [CMake] Use PRIVATE in target_link_libraries for executables

2017-12-05 Thread Shoaib Meenai via lldb-commits
Author: smeenai Date: Tue Dec 5 13:49:56 2017 New Revision: 319840 URL: http://llvm.org/viewvc/llvm-project?rev=319840=rev Log: [CMake] Use PRIVATE in target_link_libraries for executables We currently use target_link_libraries without an explicit scope specifier (INTERFACE, PRIVATE or PUBLIC)