[Lldb-commits] [lldb] r257117 - Performance improvement: Change lldb so that it puts a breakpoint

2016-01-07 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Jan 7 18:06:03 2016 New Revision: 257117 URL: http://llvm.org/viewvc/llvm-project?rev=257117=rev Log: Performance improvement: Change lldb so that it puts a breakpoint on the first branch instruction after a function return (or the end of a source line), instead of a

Re: [Lldb-commits] [PATCH] D15708: Advance the return-address breakpoint location to the end of the next source line, or the next branching instruction, when stepping over a func call

2016-01-07 Thread Jason Molenda via lldb-commits
jasonmolenda closed this revision. jasonmolenda added a comment. Landed in r257117. Sendinginclude/lldb/Target/Process.h Sendinginclude/lldb/Target/Thread.h Sendinginclude/lldb/Target/ThreadPlanStepOut.h Sendingsource/Target/Process.cpp Sending

Re: [Lldb-commits] [PATCH] D15834: Handle hardcoded breakpoints on Windows (e.g., int3 or __debugbreak())

2016-01-07 Thread Zachary Turner via lldb-commits
zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. Windows stuff looks good to me. http://reviews.llvm.org/D15834 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D15972: Make sure we don't send qModuleInfo packets unnecessarily.

2016-01-07 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D15972 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r257120 - Fix a glitch in the Driver's batch mode when used with "attach".

2016-01-07 Thread Jim Ingham via lldb-commits
Author: jingham Date: Thu Jan 7 18:20:47 2016 New Revision: 257120 URL: http://llvm.org/viewvc/llvm-project?rev=257120=rev Log: Fix a glitch in the Driver's batch mode when used with "attach". Batch mode is supposed to stop execution and return control to the user when an exceptional stop

[Lldb-commits] [lldb] r257121 - Change the key name for the libdispatch queue serial number from

2016-01-07 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Jan 7 18:20:48 2016 New Revision: 257121 URL: http://llvm.org/viewvc/llvm-project?rev=257121=rev Log: Change the key name for the libdispatch queue serial number from "qserial" to "qserialnum" because "qserial" looks a lot like the queue type (either 'serial' or

Re: [Lldb-commits] [PATCH] D15979: Fix dwarf sequence insertions

2016-01-07 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D15979 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r257113 - Better scheme to lookup alternate mangled name when looking up function address.

2016-01-07 Thread Siva Chandra via lldb-commits
Author: sivachandra Date: Thu Jan 7 17:32:34 2016 New Revision: 257113 URL: http://llvm.org/viewvc/llvm-project?rev=257113=rev Log: Better scheme to lookup alternate mangled name when looking up function address. Summary: This change is relevant for inferiors compiled with GCC. GCC does not

[Lldb-commits] [PATCH] D15972: Make sure we don't send qModuleInfo packets unnecessarily.

2016-01-07 Thread Stephane Sezer via lldb-commits
sas created this revision. sas added a reviewer: clayborg. sas added subscribers: lldb-commits, fjricci. Some debug servers don't support it so there's no point in spamming this. http://reviews.llvm.org/D15972 Files: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp

[Lldb-commits] [lldb] r257116 - Make sure we don't send qModuleInfo packets unnecessarily.

2016-01-07 Thread Stephane Sezer via lldb-commits
Author: sas Date: Thu Jan 7 18:00:17 2016 New Revision: 257116 URL: http://llvm.org/viewvc/llvm-project?rev=257116=rev Log: Make sure we don't send qModuleInfo packets unnecessarily. Summary: Some debug servers don't support it so there's no point in spamming this. Reviewers: clayborg

Re: [Lldb-commits] [PATCH] D15972: Make sure we don't send qModuleInfo packets unnecessarily.

2016-01-07 Thread Stephane Sezer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL257116: Make sure we don't send qModuleInfo packets unnecessarily. (authored by sas). Changed prior to commit: http://reviews.llvm.org/D15972?vs=44268=44288#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D15978: Prevent infinite recursive loop in AppleObjCTrampolineHandler constructor

2016-01-07 Thread Jim Ingham via lldb-commits
jingham added a comment. Can you post the backtrace in this case? It seems to me odd that CanJIT -> AllocateMemory needs to construct the AppleObjCRuntime to do its job. I'd rather cut the chain at that point if it makes sense. http://reviews.llvm.org/D15978

Re: [Lldb-commits] [PATCH] D15834: Handle hardcoded breakpoints on Windows (e.g., int3 or __debugbreak())

2016-01-07 Thread Adrian McCarthy via lldb-commits
amccarth updated this revision to Diff 44264. amccarth added a comment. Restored TestBuiltinTrap.py because that's actually for something else. Changed TestDebugbreak.py to use asm("int3") on non-Windows x86. I've ordered a Linux box, but I don't currently have one, so I haven't been able to

Re: [Lldb-commits] [PATCH] D12809: Better scheme to lookup alternate mangled name when looking up function address.

2016-01-07 Thread Siva Chandra via lldb-commits
sivachandra updated this revision to Diff 44274. sivachandra added a comment. Rebase http://reviews.llvm.org/D12809 Files: include/lldb/Symbol/ClangASTContext.h include/lldb/Symbol/CompilerDeclContext.h include/lldb/Symbol/GoASTContext.h include/lldb/Symbol/SymbolFile.h

[Lldb-commits] [lldb] r257052 - Remove some Windows->Android XTIMEOUTs

2016-01-07 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Jan 7 05:16:30 2016 New Revision: 257052 URL: http://llvm.org/viewvc/llvm-project?rev=257052=rev Log: Remove some Windows->Android XTIMEOUTs Modified: lldb/trunk/packages/Python/lldbsuite/test/dosep.py Modified: lldb/trunk/packages/Python/lldbsuite/test/dosep.py

[Lldb-commits] [PATCH] D15948: Remove duplicate header added in http://reviews.llvm.org/rL256927

2016-01-07 Thread Luke Drummond via lldb-commits
ldrumm created this revision. ldrumm added a reviewer: EwanCrawford. ldrumm added a subscriber: lldb-commits. rL256927 included a duplicate `StreamString` header file. This patch simply removes the duplicate. http://reviews.llvm.org/D15948 Files: source/Core/StringList.cpp Index:

Re: [Lldb-commits] [PATCH] D15948: Remove duplicate header added in http://reviews.llvm.org/rL256927

2016-01-07 Thread Ewan Crawford via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL257061: Remove duplicate header added in r256927 (authored by EwanCrawford). Changed prior to commit: http://reviews.llvm.org/D15948?vs=44205=44207#toc Repository: rL LLVM

[Lldb-commits] [lldb] r257068 - XFAIL TestMultithreaded on linux

2016-01-07 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Jan 7 09:24:51 2016 New Revision: 257068 URL: http://llvm.org/viewvc/llvm-project?rev=257068=rev Log: XFAIL TestMultithreaded on linux Test sometimes fails even during the reruns, upgrading to xflaky to xfail. Modified:

Re: [Lldb-commits] [PATCH] D15979: Fix dwarf sequence insertions

2016-01-07 Thread Stephane Sezer via lldb-commits
sas closed this revision. sas added a comment. Committed as r257132. http://reviews.llvm.org/D15979 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r257132 - Fix dwarf sequence insertions

2016-01-07 Thread Stephane Sezer via lldb-commits
Author: sas Date: Thu Jan 7 19:39:14 2016 New Revision: 257132 URL: http://llvm.org/viewvc/llvm-project?rev=257132=rev Log: Fix dwarf sequence insertions Summary: If two dwarf sequences begin with entries that have identical addresses, it is possible for the comparator to order the first entry

Re: [Lldb-commits] [PATCH] D15978: Prevent infinite recursive loop in AppleObjCTrampolineHandler constructor

2016-01-07 Thread Jim Ingham via lldb-commits
jingham added a comment. Cool! For completeness I think it is a good idea to do this to all the functions in InferiorCallPOSIX. For the general InferiorCall one it might be a good idea to add a defaulted (to false) parameter so that if somebody really needs to use it for something that might

Re: [Lldb-commits] [lldb] r257117 - Performance improvement: Change lldb so that it puts a breakpoint

2016-01-07 Thread Jason Molenda via lldb-commits
Thanks Siva, I'll revert the change. I have access to a linux machine but I haven't used it in a long time. Would it be easy to send me the binary (with debug info) for this test case so I can see what gcc emitted here and figure out how it went wrong? This test passes with clang on x86_64

Re: [Lldb-commits] [lldb] r257117 - Performance improvement: Change lldb so that it puts a breakpoint

2016-01-07 Thread Jason Molenda via lldb-commits
Thanks for the help with this. The problem is that lldb would try to advance the return breakpoint in no_debug_caller: (lldb) disass -b a.out`no_debug_caller: 0x4005dd <+0>: 55pushq %rbp 0x4005de <+1>: 48 89 e5 movq %rsp, %rbp 0x4005e1 <+4>:

Re: [Lldb-commits] [lldb] r257117 - Performance improvement: Change lldb so that it puts a breakpoint

2016-01-07 Thread Siva Chandra via lldb-commits
This broke TestStepNoDebug, atleast on Linux when inferior is compiled with GCC: http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/10091 I am able to reproduce this on my machine. Let me know if you need any help with anything. On Thu, Jan 7, 2016 at 4:06 PM, Jason Molenda

Re: [Lldb-commits] [PATCH] D15978: Prevent infinite recursive loop in AppleObjCTrampolineHandler constructor

2016-01-07 Thread Jim Ingham via lldb-commits
jingham added a comment. Ah, right. We're doing that so that we can make sure that an ObjC Exception thrown during the course of expression evaluation doesn't unwind past the frame we are using to call the function. Seems like for low-level stuff like AllocateMemory we should be avoiding all

Re: [Lldb-commits] [PATCH] D15978: Prevent infinite recursive loop in AppleObjCTrampolineHandler constructor

2016-01-07 Thread Jim Ingham via lldb-commits
jingham added a comment. That penultimate sentence would be clearer if I had put the end ")" in the right place - after "recursion" http://reviews.llvm.org/D15978 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D15978: Prevent infinite recursive loop in AppleObjCTrampolineHandler constructor

2016-01-07 Thread Francis Ricci via lldb-commits
fjricci created this revision. fjricci added reviewers: clayborg, jingham. fjricci added subscribers: lldb-commits, sas. When we construct AppleObjCTrampolineHandler, if m_impl_fn_addr is invalid, we call CanJIT(). If the gdb remote process does not support allocating and deallocating memory,

Re: [Lldb-commits] [PATCH] D15978: Prevent infinite recursive loop in AppleObjCTrampolineHandler constructor

2016-01-07 Thread Francis Ricci via lldb-commits
fjricci added a comment. Here's a paste of the end of the backtrace. pastebin.com/3VkF3Biq http://reviews.llvm.org/D15978 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D15979: Fix dwarf sequence insertions

2016-01-07 Thread Francis Ricci via lldb-commits
fjricci created this revision. fjricci added reviewers: clayborg, andrew.w.kaylor. fjricci added subscribers: lldb-commits, sas. If two dwarf sequences begin with entries that have identical addresses, it is possible for the comparator to order the first entry of the new sequence between the

Re: [Lldb-commits] [PATCH] D15978: Prevent infinite recursive loop in AppleObjCTrampolineHandler constructor

2016-01-07 Thread Francis Ricci via lldb-commits
fjricci added a comment. @jingham - your suggestion does avoid the recursion as well, and seems a lot cleaner. http://reviews.llvm.org/D15978 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D15978: Prevent infinite recursive loop in AppleObjCTrampolineHandler constructor

2016-01-07 Thread Francis Ricci via lldb-commits
fjricci updated this revision to Diff 44305. fjricci added a comment. Follow suggestion by @jingham to avoid setting up ObjC runtime for low-level POSIX memory allocations http://reviews.llvm.org/D15978 Files: source/Plugins/Process/Utility/InferiorCallPOSIX.cpp Index: