[Lldb-commits] [PATCH] D25668: [cmake] Respect LLVM_CMAKE_PATH in stand-alone builds for GetSVN.cmake

2016-10-17 Thread Michał Górny via lldb-commits
mgorny created this revision. mgorny added reviewers: beanz, krytarowski. mgorny added a subscriber: lldb-commits. Use LLVM_CMAKE_PATH to spawn GetSVN.cmake rather than the source path when stand-alone build is performed, to remove the unnecessary dependency on LLVM sources and use the installed

[Lldb-commits] [PATCH] D25569: Minidump plugin: functions parsing memory structures and filtering module list

2016-10-17 Thread Pavel Labath via lldb-commits
labath added inline comments. Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:15 +#include "lldb/Target/MemoryRegionInfo.h" +#include "lldb/Utility/LLDBAssert.h" + I think this is not needed anymore. Comment at:

[Lldb-commits] [lldb] r284439 - Fix a crash in expressions with fixits in the dummy target.

2016-10-17 Thread Jim Ingham via lldb-commits
Author: jingham Date: Mon Oct 17 18:59:41 2016 New Revision: 284439 URL: http://llvm.org/viewvc/llvm-project?rev=284439=rev Log: Fix a crash in expressions with fixits in the dummy target. In the expression command, if the target is NULL, you have to use the dummy target. Modified:

[Lldb-commits] [PATCH] D25714: [Test Suite] Allow overriding codesign identity

2016-10-17 Thread Chris Bieneman via lldb-commits
beanz created this revision. beanz added reviewers: zturner, tfiala. beanz added a subscriber: lldb-commits. Herald added a subscriber: mgorny. Not everyone names their code sign identity "lldb_codesign", so it is nice to allow this to be overridden. https://reviews.llvm.org/D25714 Files:

[Lldb-commits] [lldb] r284446 - More testsuite xfail markings cleanup.

2016-10-17 Thread Jim Ingham via lldb-commits
Author: jingham Date: Mon Oct 17 20:43:22 2016 New Revision: 284446 URL: http://llvm.org/viewvc/llvm-project?rev=284446=rev Log: More testsuite xfail markings cleanup. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/foundation/TestObjCMethods2.py

[Lldb-commits] [lldb] r284448 - Remove a debug print statement.

2016-10-17 Thread Jim Ingham via lldb-commits
Author: jingham Date: Mon Oct 17 20:52:32 2016 New Revision: 284448 URL: http://llvm.org/viewvc/llvm-project?rev=284448=rev Log: Remove a debug print statement. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/register_variables/TestRegisterVariables.py Modified:

[Lldb-commits] [PATCH] D25668: [cmake] Respect LLVM_CMAKE_PATH in stand-alone builds for GetSVN.cmake

2016-10-17 Thread Chris Bieneman via lldb-commits
beanz added a comment. Maybe we should define `LLVM_CMAKE_PATH` in llvm's CMakeLists.txt so that we don't need a condition here or in clang where we do the same thing? https://reviews.llvm.org/D25668 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D25668: [cmake] Respect LLVM_CMAKE_PATH in stand-alone builds for GetSVN.cmake

2016-10-17 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. This change makes sense for stand-alone builds, but if it's possible to remove branching in this CMake file - please go for it. https://reviews.llvm.org/D25668 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D25680: [cmake] Make dependencies of lldb libraries private, take 2

2016-10-17 Thread Chris Bieneman via lldb-commits
beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D25680 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] debugserver: Remove an infinitely recursive operator=

2016-10-17 Thread Justin Bogner via lldb-commits
Today I checked out lldb to check that r284364 wouldn't cause any trouble, but there were a few warnings that fired when I tried to build it, breaking my -Werror build. This deletes an unused operator= that would infinitely recurse if it were called (caught by -Winfinite-recursion). It would also

[Lldb-commits] [PATCH] unittests: Specify types in a bunch of unittest EXPECT's

2016-10-17 Thread Justin Bogner via lldb-commits
Today I checked out lldb to check that r284364 wouldn't cause any trouble, but there were a few warnings that fired when I tried to build it, breaking my -Werror build. The EXPECT and ASSERT macros in gtest don't do the usual arithmetic conversions, so there are a number of warnings where we

[Lldb-commits] [lldb] r284362 - Interpreter: Don't return StringRef from functions whose return value is never used

2016-10-17 Thread Justin Bogner via lldb-commits
Author: bogner Date: Mon Oct 17 01:17:56 2016 New Revision: 284362 URL: http://llvm.org/viewvc/llvm-project?rev=284362=rev Log: Interpreter: Don't return StringRef from functions whose return value is never used StringRef is passed through all of these APIs but never actually used. Just remove

[Lldb-commits] [PATCH] debugserver: Disable four-char-constants and format-pedantic warnings

2016-10-17 Thread Justin Bogner via lldb-commits
Today I checked out lldb to check that r284364 wouldn't cause any trouble, but there were a few warnings that fired when I tried to build it, breaking my -Werror build. This disables four character literal warnings (so that 'FDSC' in debugserver.cpp is allowed) and pedantic formatting warnings,

Re: [Lldb-commits] [PATCH] unittests: Specify types in a bunch of unittest EXPECT's

2016-10-17 Thread Justin Bogner via lldb-commits
Zachary Turner writes: > looks fine, thanks Thanks! r284405. > On Mon, Oct 17, 2016 at 10:37 AM Justin Bogner via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > >> Today I checked out lldb to check that r284364 wouldn't cause any >> trouble, but there were a few

Re: [Lldb-commits] [PATCH] unittests: Specify types in a bunch of unittest EXPECT's

2016-10-17 Thread Zachary Turner via lldb-commits
looks fine, thanks On Mon, Oct 17, 2016 at 10:37 AM Justin Bogner via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Today I checked out lldb to check that r284364 wouldn't cause any > trouble, but there were a few warnings that fired when I tried to build > it, breaking my -Werror build.

[Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

2016-10-17 Thread walter erquinigo via lldb-commits
wallace added a comment. pingping https://reviews.llvm.org/D24284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D25569: Minidump plugin: functions parsing memory structures and filtering module list

2016-10-17 Thread Dimitar Vlahovski via lldb-commits
dvlahovski added inline comments. Comment at: source/Plugins/Process/minidump/MinidumpTypes.cpp:222 + + if (header->size_of_header > sizeof(MinidumpMemoryInfoListHeader)) { +data = data.drop_front(header->size_of_header - zturner wrote: > I don't think you

[Lldb-commits] [PATCH] D25569: Minidump plugin: functions parsing memory structures and filtering module list

2016-10-17 Thread Dimitar Vlahovski via lldb-commits
dvlahovski updated this revision to Diff 74824. dvlahovski marked 11 inline comments as done. dvlahovski added a comment. Changed std::map with llvm::StringMap Using containter.empty() instead of containter.size() == 0 Avoiding copy by using for(const auto& ...) Added bitwise operations to the

[Lldb-commits] [PATCH] D25677: Minidump plugin: redesign the x86_64 register context

2016-10-17 Thread Dimitar Vlahovski via lldb-commits
dvlahovski created this revision. dvlahovski added reviewers: labath, zturner. dvlahovski added subscribers: amccarth, lldb-commits. I misunderstood the format of the register context layout. I thought it was a dynamically changing structure, and that it's size depended on context_flags. It

[Lldb-commits] [PATCH] D25681: [PseudoTerminal] Fix PseudoTerminal MSVC release crash

2016-10-17 Thread Rudy Pons via lldb-commits
Ilod created this revision. Ilod added reviewers: zturner, carlokok. Ilod added a subscriber: lldb-commits. Since r278177, the Posix functions in PseudoTerminal::OpenFirstAvailableMaster on windows are now inlined LLVM_UNREACHABLE instead of return 0. This causes __assume(0) to be inlined in

[Lldb-commits] [PATCH] D25677: Minidump plugin: redesign the x86_64 register context

2016-10-17 Thread Dimitar Vlahovski via lldb-commits
dvlahovski updated this revision to Diff 74852. dvlahovski added a comment. Adding sanity check for the context's size https://reviews.llvm.org/D25677 Files: source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.cpp source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.h

[Lldb-commits] [PATCH] D25677: Minidump plugin: redesign the x86_64 register context

2016-10-17 Thread Pavel Labath via lldb-commits
labath added a comment. Comment at: source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.cpp:61 + if (source_data.size() < sizeof(MinidumpContext_x86_64)) +return result_context_buf; This looks like error handling. Should we return an empty

[Lldb-commits] [PATCH] D25569: Minidump plugin: functions parsing memory structures and filtering module list

2016-10-17 Thread Pavel Labath via lldb-commits
labath added a comment. looks good as far as i am concerned https://reviews.llvm.org/D25569 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D25680: [cmake] Make dependencies of lldb libraries private, take 2

2016-10-17 Thread Pavel Labath via lldb-commits
labath created this revision. labath added reviewers: zturner, beanz. labath added a subscriber: lldb-commits. Herald added subscribers: mgorny, ki.stfu. The dependencies of our libraries (only liblldb, really) we marked as public, which caused all their dependencies to be repeated when linking

[Lldb-commits] [PATCH] D25677: Minidump plugin: redesign the x86_64 register context

2016-10-17 Thread Dimitar Vlahovski via lldb-commits
dvlahovski updated this revision to Diff 74856. dvlahovski added a comment. Return a nullptr in case of an error https://reviews.llvm.org/D25677 Files: source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.cpp source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.h

[Lldb-commits] [PATCH] D25677: Minidump plugin: redesign the x86_64 register context

2016-10-17 Thread Dimitar Vlahovski via lldb-commits
dvlahovski updated this revision to Diff 74859. dvlahovski added a comment. Make a single array of sse registers instead of separated fields https://reviews.llvm.org/D25677 Files: source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.cpp

[Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

2016-10-17 Thread walter erquinigo via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284422: [lldb] Read modules from memory when a local copy is not available (authored by wallace). Changed prior to commit: https://reviews.llvm.org/D24284?vs=72597=74895#toc Repository: rL LLVM

Re: [Lldb-commits] [lldb] r284362 - Interpreter: Don't return StringRef from functions whose return value is never used

2016-10-17 Thread Zachary Turner via lldb-commits
lgtm On Mon, Oct 17, 2016 at 10:37 AM Justin Bogner via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: bogner > Date: Mon Oct 17 01:17:56 2016 > New Revision: 284362 > > URL: http://llvm.org/viewvc/llvm-project?rev=284362=rev > Log: > Interpreter: Don't return StringRef from

[Lldb-commits] [lldb] r284405 - unittests: Specify types in a bunch of unittest EXPECT's

2016-10-17 Thread Justin Bogner via lldb-commits
Author: bogner Date: Mon Oct 17 13:22:03 2016 New Revision: 284405 URL: http://llvm.org/viewvc/llvm-project?rev=284405=rev Log: unittests: Specify types in a bunch of unittest EXPECT's The EXPECT and ASSERT macros in gtest don't do the usual arithmetic conversions. Specify types in several of

[Lldb-commits] [lldb] r284422 - [lldb] Read modules from memory when a local copy is not available

2016-10-17 Thread Walter Erquinigo via lldb-commits
Author: wallace Date: Mon Oct 17 15:28:19 2016 New Revision: 284422 URL: http://llvm.org/viewvc/llvm-project?rev=284422=rev Log: [lldb] Read modules from memory when a local copy is not available Summary: When the local lldb doesn't have access to a copy of the modules in the target, e.g.

[Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

2016-10-17 Thread Zachary Turner via lldb-commits
zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. This looks fine now. Sorry for the delay, I had forgotten about it. I think you still don't have commit access right? Now would be a good time to request it