[Lldb-commits] [PATCH] D27305: Replace __ANDROID_NDK__ with simply ANDROID

labath added a comment. I've tried to unify this slightly, but sometimes further unification would make things inconsistent with surrounding preprocessor directives. I was suprised by the presence of some of these ifdefs as well -- some of them seem completely unnecessary. I think that at some

[Lldb-commits] [lldb] r288494 - Replace __ANDROID_NDK__ with __ANDROID__

Author: labath Date: Fri Dec 2 05:15:15 2016 New Revision: 288494 URL: http://llvm.org/viewvc/llvm-project?rev=288494=rev Log: Replace __ANDROID_NDK__ with __ANDROID__ Summary: This replaces all the uses of the __ANDROID_NDK__ define with __ANDROID__. This is a preparatory step to remove our

[Lldb-commits] [PATCH] D27305: Replace __ANDROID_NDK__ with simply ANDROID

labath updated this revision to Diff 80047. labath added a comment. A bit more cleanup. https://reviews.llvm.org/D27305 Files: cmake/platforms/Android.cmake include/lldb/Core/RegularExpression.h include/lldb/Host/Config.h include/lldb/Host/Editline.h include/lldb/Host/Host.h

[Lldb-commits] [PATCH] D27305: Replace __ANDROID_NDK__ with simply ANDROID

This revision was automatically updated to reflect the committed changes. Closed by commit rL288494: Replace __ANDROID_NDK__ with __ANDROID__ (authored by labath). Changed prior to commit: https://reviews.llvm.org/D27305?vs=80047=80048#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D27289: Return "thread-pcs" in jstopinfo on Linux/Android.

labath added a comment. In https://reviews.llvm.org/D27289#611082, @jasonmolenda wrote: > @labath ah I see I hadn't looked at the lldb-server packets so I didn't know > you had jThreadsInfo, good to hear. Yes, if your target is built mostly > -fomit-frame-pointer, lldb-server won't be able to

[Lldb-commits] [PATCH] D27305: Replace __ANDROID_NDK__ with simply ANDROID

labath updated this revision to Diff 80043. labath added a comment. Update to use __ANDROID__ https://reviews.llvm.org/D27305 Files: cmake/platforms/Android.cmake include/lldb/Core/RegularExpression.h include/lldb/Host/Config.h include/lldb/Host/Editline.h include/lldb/Host/Host.h

[Lldb-commits] [PATCH] D27305: Replace __ANDROID_NDK__ with simply ANDROID

tberghammer added inline comments. Comment at: include/lldb/Core/RegularExpression.h:34 #else -#if __ANDROID_NDK__ +#if ANDROID #include In most case you use "#ifdef". It would be nice to uniformalize Comment at:

Re: [Lldb-commits] [lldb] r288542 - Update test expectations after AddressSanitizer text descriptions changed in r288535.

Thanks, Kuba! On Fri, Dec 2, 2016 at 2:11 PM, Kuba Mracek via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: kuba.brecka > Date: Fri Dec 2 16:11:26 2016 > New Revision: 288542 > > URL: http://llvm.org/viewvc/llvm-project?rev=288542=rev > Log: > Update test expectations after

[Lldb-commits] [PATCH] D27380: [lldb] Update the check for Linux or FreeBSD in SymbolFileDWARF::FindFunctions.

alexshap created this revision. alexshap added reviewers: clayborg, spyffe. alexshap added a subscriber: lldb-commits. alexshap set the repository for this revision to rL LLVM. This diff 1. Adds a comment to ObjectFileELF.cpp about the current approach to determining the OS. 2. Replaces the

[Lldb-commits] [PATCH] D27017: Support more report types in AddressSanitizerRuntime.cpp

filcab accepted this revision. filcab added a comment. LGTM (I commented on a minor nit. It might just be me, so feel free to keep the current wording if you feel it's preferred) https://reviews.llvm.org/D27017 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D27017: Support more report types in AddressSanitizerRuntime.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rL288535: Support more report types in AddressSanitizerRuntime.cpp, re-word existing ones. (authored by kuba.brecka). Changed prior to commit: https://reviews.llvm.org/D27017?vs=79611=80123#toc

[Lldb-commits] [PATCH] D27017: Support more report types in AddressSanitizerRuntime.cpp

kubabrecka added a comment. Thanks for reviewing this! Repository: rL LLVM https://reviews.llvm.org/D27017 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D27017: Support more report types in AddressSanitizerRuntime.cpp

kubabrecka added a comment. In https://reviews.llvm.org/D27017#611894, @filcab wrote: > LGTM > > (I commented on a minor nit. It might just be me, so feel free to keep the > current wording if you feel it's preferred) I'm not seeing this comment. Can you post it again?

Re: [Lldb-commits] [PATCH] D27017: Support more report types in AddressSanitizerRuntime.cpp

.Case("stack-use-after-return", "Use of returned stack memory") Maybe "Use of stack memory after (function) return"? (i couldn't decide whether to include "function". Either delete it or delete the parens. This is a very minor nit, so I'm ok with keeping the current wording if you prefer that.

Re: [Lldb-commits] [PATCH] D27289: Return "thread-pcs" in jstopinfo on Linux/Android.

> On Dec 2, 2016, at 2:47 AM, Pavel Labath via Phabricator via lldb-commits > wrote: > > labath added a comment. > > In https://reviews.llvm.org/D27289#611082, @jasonmolenda wrote: > >> @labath ah I see I hadn't looked at the lldb-server packets so I didn't know

[Lldb-commits] [PATCH] D27289: Return "thread-pcs" in jstopinfo on Linux/Android.

jasonmolenda added a comment. @labath intersting idea, sending a blob of stack memory above the current stack pointer reg value to accelerate an unwind. If you have a lot of small stack frames, it could be a performance benefit. Common/simple methods do their work in 32-64 bytes of stack

Re: [Lldb-commits] [PATCH] D27017: Support more report types in AddressSanitizerRuntime.cpp

This commit is causing tests to fail in Darwin: TestReportData.AsanTestReportDataCase TestMemoryHistory.AsanTestCase http://lab.llvm.org:8080/green/job/lldb_build_test/22768/ http://lab.llvm.org:8080/green/job/lldb_build_test/22769/ FAIL: test_dwarf (TestReportData.AsanTestReportDataCase)

[Lldb-commits] [lldb] r288542 - Update test expectations after AddressSanitizer text descriptions changed in r288535.

Author: kuba.brecka Date: Fri Dec 2 16:11:26 2016 New Revision: 288542 URL: http://llvm.org/viewvc/llvm-project?rev=288542=rev Log: Update test expectations after AddressSanitizer text descriptions changed in r288535. Modified: