[Lldb-commits] [PATCH] D28616: Remove a couple of Stream flags

2017-01-12 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. Yeah, I'm starting to remember this a bit. For some reason, we have individual log channels with verbose as a category (LIBLLDB_LOG_VERBOSE, POSIX_LOG_VERBOSE, KDP_LOG_VERBOSE) and we have LLDB_LOG_OPTION_VERBOSE which is set "GetVerbose" is testing for. So you can

[Lldb-commits] [lldb] r291756 - Fix build for clang r291753

2017-01-12 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Jan 12 04:44:16 2017 New Revision: 291756 URL: http://llvm.org/viewvc/llvm-project?rev=291756=rev Log: Fix build for clang r291753 Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp URL:

[Lldb-commits] [lldb] r291759 - Add format_provider for the Error class

2017-01-12 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Jan 12 05:13:24 2017 New Revision: 291759 URL: http://llvm.org/viewvc/llvm-project?rev=291759=rev Log: Add format_provider for the Error class Summary: The formatter supports the same options as the string-like classes, i.e. the ability to truncate the displayed string.

[Lldb-commits] [PATCH] D28519: Add format_provider for the Error class

2017-01-12 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL291759: Add format_provider for the Error class (authored by labath). Changed prior to commit: https://reviews.llvm.org/D28519?vs=83813=84098#toc Repository: rL LLVM https://reviews.llvm.org/D28519

[Lldb-commits] [lldb] r291763 - Fix gcc build for r291756

2017-01-12 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Jan 12 05:36:56 2017 New Revision: 291763 URL: http://llvm.org/viewvc/llvm-project?rev=291763=rev Log: Fix gcc build for r291756 I have accidentally added extra llvm:: namespace qualification. Modified: lldb/trunk/include/lldb/Core/Error.h Modified:

[Lldb-commits] [PATCH] D27459: Straw-man proposal for new logging syntax

2017-01-12 Thread Pavel Labath via Phabricator via lldb-commits
labath updated this revision to Diff 84108. labath added a comment. - Several people expressed wishes to have this off by default, so I have done that. - Renamed the log option to --file-function (Note I am deliberately not printing the line numbers -- they tend to change all the time and it's

[Lldb-commits] [PATCH] D28616: Remove a couple of Stream flags

2017-01-12 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In https://reviews.llvm.org/D28616#644287, @jingham wrote: > Is this going to make passing LIBLLDB_LOG_OPTION_VERBOSE to > GetLogIfAllCategoriesSet into a "you can't see these logs" operation? > > I use this in a couple places where I have detailed information that I

[Lldb-commits] [PATCH] D28616: Remove a couple of Stream flags

2017-01-12 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: clayborg, zturner. labath added subscribers: lldb-commits, beanz. Herald added a subscriber: aprantl. I came across this while trying to understand what Log::Debug does. It turns out it does not do anything, as there is no instance of someone

[Lldb-commits] [PATCH] D28616: Remove a couple of Stream flags

2017-01-12 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Most of the DWARF stuff is about to go away anyway in favor of using the LLVM DWARF parser as I am currently modifying it to support all we need in LLDB so we can get rid of the entire

[Lldb-commits] [lldb] r291788 - [CMake] Fix finding LLDBWrapPython.cpp in Framework build

2017-01-12 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Thu Jan 12 12:45:59 2017 New Revision: 291788 URL: http://llvm.org/viewvc/llvm-project?rev=291788=rev Log: [CMake] Fix finding LLDBWrapPython.cpp in Framework build The framework build was constructing the path to LLDBWrapPython incorrectly. It is apparently always in

[Lldb-commits] [PATCH] D28616: Remove a couple of Stream flags

2017-01-12 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. Is this going to make passing LIBLLDB_LOG_OPTION_VERBOSE to GetLogIfAllCategoriesSet into a "you can't see these logs" operation? I use this in a couple places where I have detailed information that I usually don't want to see, but in some odd cases I might need it.