[Lldb-commits] [PATCH] D35223: Report inferior SIGSEGV/SIGILL/SIGBUS/SIGFPE as a signal instead of an exception on freebsd

labath added a comment. In https://reviews.llvm.org/D35223#834050, @emaste wrote: > With this patch I observed three new failures on FreeBSD and three new > unexpected passes on FreeBSD. An example of a new failure: > > == >

[Lldb-commits] [lldb] r310341 - Checking in files accidentally missed in later diffs of revision r310261

Author: abhishek Date: Tue Aug 8 02:25:50 2017 New Revision: 310341 URL: http://llvm.org/viewvc/llvm-project?rev=310341&view=rev Log: Checking in files accidentally missed in later diffs of revision r310261 -- 2 files were missing in this commit which should have been there. These files wer

Re: [Lldb-commits] [PATCH] D35223: Report inferior SIGSEGV/SIGILL/SIGBUS/SIGFPE as a signal instead of an exception on freebsd

> On Aug 8, 2017, at 12:02 AM, Pavel Labath via Phabricator via lldb-commits > wrote: > > labath added a comment. > > In https://reviews.llvm.org/D35223#834050, @emaste wrote: > >> With this patch I observed three new failures on FreeBSD and three new >> unexpected passes on FreeBSD. An exam

[Lldb-commits] [PATCH] D35223: Report inferior SIGSEGV/SIGILL/SIGBUS/SIGFPE as a signal instead of an exception on freebsd

emaste added a comment. > Actually, I think you probably need to extend the @skipIfLinux to apply to > freebsd as well. Oh, I mistook the source of the check_stop_reason assertion failure -- I thought it was asserting before the step. In this case I agree the test should be skipped on FreeBSD.

[Lldb-commits] [PATCH] D36485: Add existing unit tests to Xcode project

penryu created this revision. This adds gtest test files to the Xcode project which were previously only in the cmake config. This is the first of several planned merges. https://reviews.llvm.org/D36485 Files: lldb.xcodeproj/project.pbxproj Index: lldb.xcodeproj/project.pbxproj =

[Lldb-commits] [PATCH] D36485: Add existing unit tests to Xcode project

penryu added a comment. Note that VASprintfTest.cpp is added to the xcodeproj but not added to the lldb-gtest-build target _YET_. It needs some work before I can enable it. https://reviews.llvm.org/D36485 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [PATCH] D36485: Add existing unit tests to Xcode project

penryu edited reviewers, added: spyffe, jingham; removed: zturner, labath. penryu added a comment. This is really an Xcode-only change. https://reviews.llvm.org/D36485 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/c

[Lldb-commits] [PATCH] D36485: Add existing unit tests to Xcode project

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D36485 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[Lldb-commits] [lldb] r310417 - Add existing unit tests to Xcode project

Author: penryu Date: Tue Aug 8 13:59:20 2017 New Revision: 310417 URL: http://llvm.org/viewvc/llvm-project?rev=310417&view=rev Log: Add existing unit tests to Xcode project Summary: This adds gtest test files to the Xcode project which were previously only in the cmake config. This is the first

[Lldb-commits] [PATCH] D36485: Add existing unit tests to Xcode project

penryu added a comment. Committing 'https://reviews.llvm.org/D36485: Add existing unit tests to Xcode project'... Sendinglldb.xcodeproj/project.pbxproj Transmitting file data .done Committing transaction... Committed revision 310417. Closing revision https://reviews.llvm.org/D36485 'Add e

[Lldb-commits] [PATCH] D36496: Fix VASprintfTest.cpp for Darwin, add checks

penryu created this revision. The EncodingError test ensures that trying to encode a multibyte wchar with a given codepage fails. If setlocale() fails, the encoding is performed using the current locale, which may or may not fail. This patch asserts that both setlocale() operations are successful

[Lldb-commits] [PATCH] D36496: Fix VASprintfTest.cpp for Darwin, add checks

penryu added a comment. I'd prototyped this as simply prepending "DISABLED_" for non-Windows, but as this was designed as a temporary measure, I decided to ensure the same behavior was tested on Windows, and similar/equivalent behavior tested on other platforms. https://reviews.llvm.org/D3649