labath accepted this revision.
labath added a comment.
lgtm
https://reviews.llvm.org/D34776
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tberghammer updated this revision to Diff 111326.
tberghammer added a comment.
Add comment about the MIPS special case.
https://reviews.llvm.org/D36046
Files:
source/Core/ArchSpec.cpp
source/Plugins/Process/elf-core/ProcessElfCore.cpp
Index:
tberghammer added a comment.
Hi Greg, can you take a look sometime? Thanks, Tamas
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:733-735
+ if (target_arch.IsMIPS()) {
return target_arch;
+ }
nitesh.jain wrote:
> tberghammer wrote:
> > Hi
Author: tberghammer
Date: Wed Aug 16 04:45:10 2017
New Revision: 311000
URL: http://llvm.org/viewvc/llvm-project?rev=311000=rev
Log:
Remove the DWARFExpression -> Clang ExpressionParser dependency
It was completly unused and broke the part of the encapsulation that
common code shouldn't depend
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311002: Make i386-*-freebsd expression work on JIT path
(authored by emaste).
Changed prior to commit:
https://reviews.llvm.org/D34776?vs=104984=111331#toc
Repository:
rL LLVM
Author: emaste
Date: Wed Aug 16 06:10:07 2017
New Revision: 311003
URL: http://llvm.org/viewvc/llvm-project?rev=311003=rev
Log:
convert hard tabs to spaces in PlatformOpenBSD.cpp
Another case of this was responsible for the whitespace conflict
in D34776.
Modified:
Author: emaste
Date: Wed Aug 16 05:55:02 2017
New Revision: 311002
URL: http://llvm.org/viewvc/llvm-project?rev=311002=rev
Log:
Make i386-*-freebsd expression work on JIT path
* Enable i386 ABI creation for freebsd
* Added an extra argument in ABISysV_i386::PrepareTrivialCall for mmap
syscall
cbook added a comment.
Thanks Jason. I don't have commit access. Would you or someone else be able
to commit this?
https://reviews.llvm.org/D36620
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
jasonmolenda added a comment.
This looks good, the documentation for isprint() say that the value of the
argument must be representable as an unsigned char, or EOF.
https://reviews.llvm.org/D36620
___
lldb-commits mailing list
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine. Sorry for the delay.
https://reviews.llvm.org/D36046
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
10 matches
Mail list logo