labath added reviewers: clayborg, jingham.
labath added a comment.
This seems like a good idea to me (but Greg or Jim should review this).
Could you please also add a test case for this. It looks like you already have
a simple program in the bug you linked, so it should be just a matter of
labath added inline comments.
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:488
+ELFNote note = ELFNote();
+note.Parse(segment, );
+
clayborg wrote:
> Do we need to check anything after parsing a note here to ensure it parsed?
> Can
labath updated this revision to Diff 123816.
labath added a comment.
Address review comments.
https://reviews.llvm.org/D40311
Files:
source/Plugins/Process/elf-core/ProcessElfCore.cpp
source/Plugins/Process/elf-core/ProcessElfCore.h
source/Plugins/Process/elf-core/ThreadElfCore.cpp
clayborg added inline comments.
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:488
+ELFNote note = ELFNote();
+note.Parse(segment, );
+
Do we need to check anything after parsing a note here to ensure it parsed? Can
offset end up not
labath created this revision.
We've had a single function responsible for splitting a core segment
into notes, and parsing the notes themselves, bearing in mind variations
between 4 supported OS types. This commit splits that code into 5
pieces:
- (os-independent) code for splitting a segment
labath planned changes to this revision.
labath added a comment.
I am going to come back to this later, with a slightly different approach, but
first I need to do another cleanup elsewhere.
https://reviews.llvm.org/D40133
___
lldb-commits mailing
krytarowski added inline comments.
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:735
/// (see ELFNote structure)
/// 3) A Thread Context in a core file usually described by 3 NOTE entries.
///a) NT_PRSTATUS - Register context
Can we
