Re: [Lldb-commits] [lldb] r319653 - Makefile.rules: compile all tests with -fno-limit-debug-info

> On Dec 6, 2017, at 9:35 AM, Robinson, Paul wrote: > >> -Original Message- >> From: Pavel Labath [mailto:lab...@google.com] >> Sent: Wednesday, December 06, 2017 4:09 AM >> To: Jason Molenda >> Cc: lldb-commits@lists.llvm.org; Robinson, Paul >> Subject: Re:

[Lldb-commits] [PATCH] D40812: Remove no-op null checks, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL319936: Remove no-op function pointer null checks, NFC (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D40812?vs=125437=125773#toc Repository: rL LLVM

Re: [Lldb-commits] [lldb] r319597 - Fix warning in DynamicLoaderDarwinKernel.cpp, NFC

> On Dec 2, 2017, at 12:22 PM, Davide Italiano wrote: > > On Fri, Dec 1, 2017 at 3:53 PM, Vedant Kumar via lldb-commits > wrote: >> Author: vedantk >> Date: Fri Dec 1 15:53:01 2017 >> New Revision: 319597 >> >> URL:

[Lldb-commits] [lldb] r319934 - [MappedHash] Fix alignment violations

Author: vedantk Date: Wed Dec 6 11:21:08 2017 New Revision: 319934 URL: http://llvm.org/viewvc/llvm-project?rev=319934=rev Log: [MappedHash] Fix alignment violations This fixes a few alignment problems pointed out by UBSan, and is otherwise NFC. Modified:

[Lldb-commits] [lldb] r319935 - Use a static_cast instead of a C cast, NFC

Author: vedantk Date: Wed Dec 6 11:21:09 2017 New Revision: 319935 URL: http://llvm.org/viewvc/llvm-project?rev=319935=rev Log: Use a static_cast instead of a C cast, NFC Pointed out by Davide Italiano in post-commit review. Modified:

[Lldb-commits] [lldb] r319939 - Fix const-correctness in RegisterContext methods, NFC

Author: vedantk Date: Wed Dec 6 11:21:12 2017 New Revision: 319939 URL: http://llvm.org/viewvc/llvm-project?rev=319939=rev Log: Fix const-correctness in RegisterContext methods, NFC A few methods in RegisterContext classes accept const objects which are cast to a non-const thread_state_t. Drop

[Lldb-commits] [lldb] r319937 - Fix misc -Wcast-qual warnings, NFC

Author: vedantk Date: Wed Dec 6 11:21:11 2017 New Revision: 319937 URL: http://llvm.org/viewvc/llvm-project?rev=319937=rev Log: Fix misc -Wcast-qual warnings, NFC Modified: lldb/trunk/tools/debugserver/source/MacOSX/MachProcess.mm lldb/trunk/tools/debugserver/source/MacOSX/MachTask.mm

[Lldb-commits] [lldb] r319938 - Fix an -Wunused-function warning, NFC

Author: vedantk Date: Wed Dec 6 11:21:11 2017 New Revision: 319938 URL: http://llvm.org/viewvc/llvm-project?rev=319938=rev Log: Fix an -Wunused-function warning, NFC Modified: lldb/trunk/tools/debugserver/source/MacOSX/MachProcess.mm Modified:

[Lldb-commits] [lldb] r319936 - Remove no-op function pointer null checks, NFC

Author: vedantk Date: Wed Dec 6 11:21:10 2017 New Revision: 319936 URL: http://llvm.org/viewvc/llvm-project?rev=319936=rev Log: Remove no-op function pointer null checks, NFC Null-checking functions which aren't marked weak_import is a no-op (the compiler rewrites the check to 'true'),

[Lldb-commits] [PATCH] D40821: Fix const-correctness in RegisterContext methods, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL319939: Fix const-correctness in RegisterContext methods, NFC (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D40821?vs=125639=125774#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D40557: Variable: Fix usage of uninitialised value

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Sorry for the delay. That bug has been present since this function was added, so it doesn't look like there was a use for these parameters that got lost as the code evolved. So this seems

[Lldb-commits] [lldb] r319943 - Fix the -Wunused-function warning properly (MachProcess.mm)

Author: vedantk Date: Wed Dec 6 11:27:20 2017 New Revision: 319943 URL: http://llvm.org/viewvc/llvm-project?rev=319943=rev Log: Fix the -Wunused-function warning properly (MachProcess.mm) r319938 was not NFC, because it got the preprocessor guard wrong. Check WITH_FBS and WITH_BKS before

Re: [Lldb-commits] [lldb] r319653 - Makefile.rules: compile all tests with -fno-limit-debug-info

I'll fix this now (my top priority :) On Wed, Dec 6, 2017 at 9:44 AM, Adrian Prantl wrote: > > >> On Dec 6, 2017, at 9:35 AM, Robinson, Paul wrote: >> >>> -Original Message- >>> From: Pavel Labath [mailto:lab...@google.com] >>> Sent: Wednesday,

Re: [Lldb-commits] [lldb] r319653 - Makefile.rules: compile all tests with -fno-limit-debug-info

> -Original Message- > From: Pavel Labath [mailto:lab...@google.com] > Sent: Wednesday, December 06, 2017 4:09 AM > To: Jason Molenda > Cc: lldb-commits@lists.llvm.org; Robinson, Paul > Subject: Re: [Lldb-commits] [lldb] r319653 - Makefile.rules: compile all > tests with

[Lldb-commits] [lldb] r319953 - [lldb] Use PRIVATE in target_link_libraries

Author: smeenai Date: Wed Dec 6 12:53:03 2017 New Revision: 319953 URL: http://llvm.org/viewvc/llvm-project?rev=319953=rev Log: [lldb] Use PRIVATE in target_link_libraries This is a follow-up to r319840. I guess none of the systems I'd tested on before had LLDB_SYSTEM_LIBS set, which is why I

Re: [Lldb-commits] [PATCH] D40745: Add a clang-ast subcommand to lldb-test

On 5 December 2017 at 17:44, Greg Clayton wrote: > Didn't someone recently submit a patch to allow relocation of .o files? That > should have taken care of the issue, no? > I take it you mean D38142. This made sure that the memory we store the object file in is writable,

[Lldb-commits] [PATCH] D40757: Disable warnings related to anonymous types in the ObjC plugin

vsk updated this revision to Diff 125816. vsk retitled this revision from "Disable warnings related to anonymous types" to "Disable warnings related to anonymous types in the ObjC plugin". vsk edited the summary of this revision. vsk added a comment. - Thanks @labath! I've disabled the GNU

[Lldb-commits] [PATCH] D40557: Variable: Fix usage of uninitialised value

labath added a comment. Jim, could you have a quick look at this? thanks. https://reviews.llvm.org/D40557 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [lldb] r319653 - Makefile.rules: compile all tests with -fno-limit-debug-info

On 6 December 2017 at 01:54, Jason Molenda wrote: > It looks like the macos testsuite on the bot is broken with this - > > http://lab.llvm.org:8080/green/view/LLDB/job/lldb/3086/ > > On my desktop with a recent clang, it works fine. But it seems like every > test? most